yes, that sounds good to me
PoAn Yang 於 2025年8月3日 週日 下午7:23寫道：
> Hi Chia-Ping,
>
> chia_02: Yes, it’s better to return TimeoutException if the node
> is not available. However, for FeatureCommand, we can follow
> ReassignPartitionsCommand to return AdminCommandFailedException.
> WDYT?
>
>
> http
Hi Chia-Ping,
chia_02: Yes, it’s better to return TimeoutException if the node
is not available. However, for FeatureCommand, we can follow
ReassignPartitionsCommand to return AdminCommandFailedException.
WDYT?
https://github.com/apache/kafka/blob/ea771563e0b5f047027ab1ffa67d976d8df26864/tools/sr
chia_02: If the node is nonexistent, the API throws
BrokerIdNotRegisteredException.
I added related test cases to test plan.
Throwing BrokerIdNotRegisteredException seems a bit odd to me, since the
broker may be temporarily unavailable. Perhaps, it should throw a
`TimeoutException`, similar to `i
Hi Chia-Ping,
Thanks for the great suggestion.
chia_02: If the node is nonexistent, the API throws
BrokerIdNotRegisteredException.
I added related test cases to test plan.
chia_03: Added KIP-1180 to alternatives section.
Thanks,
PoAn
> On Aug 1, 2025, at 3:11 PM, Chia-Ping Tsai wrote:
>
> h
hi Poan
chia_02: what happens if the specific node is nonexistent? Could you please add
the case to the test plan?
chia_03: we have another KIP that exposes the versions through metrics. Could
you please expand the rejected alternatives section regarding the option of
“using metrics”?
Best,
Hi Chia-Ping,
Thanks for the review.
chia_00: Updated the comment of `DescribeFeaturesOptions#nodeId` function.
chia_01: Updated the returned type of `DescribeFeaturesOptions#nodeId` to
`OptionalInt` and changed the default value as `OptionalInt.empty()`.
Thanks,
PoAn
> On Jul 23, 2025, at 2
hi PoAn
thanks for this KIP. Please take a look at following questions.
chia_00:
The behavior of "-1" defined by `DescribeFeaturesOptions#nodeId` is too
detailed. That could obstructs us from tweaking the behavior in the future.
Perhaps we could use "arbitrary controller/broker" instead.
chia
Hey PoAn,
I guess today folks would just have to dig through the logs to figure out
supported versions of each node.
Being able to retrieve feature levels for a specific node seems like a
reasonable addition to the kafka-features tool, thanks for the KIP!
Best,
Alyssa
On Mon, Jun 16, 2025 at 7:2
Hi all,
I would like to manually bump this thread.
If there's no further feedback, I'll start the vote next Monday.
Thanks,
PoAn
On 2025/04/15 14:01:18 PoAn Yang wrote:
> Hi all,
>
> I would like to start a discussion thread on KIP-1160.
>
> It adds node id to DescribeFeaturesOptions, so Admi
