Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config

2025-04-14 Thread PoAn Yang
_CONFIG_RESOURCES. > > Thanks, > Andrew > > From: Chia-Ping Tsai > Sent: 04 April 2025 11:03 > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has > dynamic config > >> chi

Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config

2025-04-11 Thread Andrew Schofield
From: Chia-Ping Tsai Sent: 04 April 2025 11:03 To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config > chia_2: We can do the best to improve user experience. For v1 request, if the admin client receives UNSUPPORTED_VERSION er

Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config

2025-04-05 Thread PoAn Yang
Hi all, If there is no further discussion, I will start vote thread for KIP-1142 tomorrow. Thanks, PoAn > On Mar 16, 2025, at 5:23 PM, PoAn Yang wrote: > > Hi Andrew, > > Thanks for the review. > > AS1: The kafka-client-metrics.sh —describe —name for a non-existent > client-metric shows de

Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config

2025-04-04 Thread PoAn Yang
Hi Andrew and Chia-Ping, Thanks for the review. AS5: My mistake. Remove the specific named entity. The “—describe —entity-type groups” lists active and non-active groups which having configuration resources. > It seems that the new ListConfigResources RPC would be able > to list all config reso

Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config

2025-04-04 Thread Chia-Ping Tsai
> chia_2: We can do the best to improve user experience. For v1 request, if the admin client receives UNSUPPORTED_VERSION error and the request body only contains client metric resource type, the admin client can fall back to use v0 request. In other cases, such as when the resource type is empty o

Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config

2025-04-04 Thread PoAn Yang
Hi Chia-Ping, chia_2: We can do the best to improve user experience. For v1 request, if the admin client receives UNSUPPORTED_VERSION error and the request body only contains client metric resource type, the admin client can fall back to use v0 request. In other cases, such as when the resource

Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config

2025-04-03 Thread Chia-Ping Tsai
hi PoAn thanks for this kip. A couple of questions are listed below. chia_0: Should `listConfigs` be renamed to `listConfigResources` to match the returned type? chia_1: v0 returns only the ClientMetricsResource, right? If so, could you please add docs to the protocol file and KIP chia_2:

Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config

2025-04-02 Thread Andrew Schofield
r the groups are active or not. Thanks, Andrew Sent from Outlook for Mac From: PoAn Yang Date: Wednesday, 2 April 2025 at 03:11 To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config Hi all, If there is no further discussion, I

Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config

2025-03-16 Thread PoAn Yang
Hi Andrew, Thanks for the review. AS1: The kafka-client-metrics.sh —describe —name for a non-existent client-metric shows default configuration. The behavior is inconsistent with kafka-configs.sh in this KIP. I add this case to proposed changes as well. Thanks. AS2: Thanks for the great sugges

Re: [DISCUSS] KIP-1142: Allow to list non-existent group which has dynamic config

2025-03-14 Thread Andrew Schofield
Hi PoAn, Thanks for the KIP. It would certainly be good to fix this slightly odd behaviour in Kafka configs. AS1: I'd like to confirm that the KIP also alters the behaviour of kafka-client-metrics.sh --describe for the case where the resource does not exist. You do show this in an example, but