Re: [EXTERNAL] Re: [DISCUSS] KIP-280: Enhanced log compaction

2019-12-18 Thread Guozhang Wang
Regards, > Senthil > > -Original Message- > From: radai > Sent: Thursday, December 12, 2019 11:40 AM > To: dev@kafka.apache.org > Subject: Re: [EXTERNAL] Re: [DISCUSS] KIP-280: Enhanced log compaction > > may I suggest that if, under "header" strategy, multiple

RE: [EXTERNAL] Re: [DISCUSS] KIP-280: Enhanced log compaction

2019-12-16 Thread Senthilnathan Muthusamy
current KIP... Appreciate your valuable feedback! Regards, Senthil -Original Message- From: radai Sent: Thursday, December 12, 2019 11:40 AM To: dev@kafka.apache.org Subject: Re: [EXTERNAL] Re: [DISCUSS] KIP-280: Enhanced log compaction may I suggest that if, under "header"

Re: [EXTERNAL] Re: [DISCUSS] KIP-280: Enhanced log compaction

2019-12-12 Thread radai
may I suggest that if, under "header" strategy, multiple records are found with identical header values they are ALL kept? this would be useful in cases where users send larger payloads than max record size to kafka and are forced to fragment them - by setting the same header in all fragments it wo

RE: [EXTERNAL] Re: [DISCUSS] KIP-280: Enhanced log compaction

2019-11-26 Thread Senthilnathan Muthusamy
Thanks Jun for confirming! I have updated the KIP (added recommendation section and special case in handling LEO record for non-offset based compaction strategy). Please review and let me know if you have any other feedback. Regards, Senthil -Original Message- From: Jun Rao Sent: Tue