Re: Pull-Requests not worked on

2017-06-19 Thread Ismael Juma
No, only Apache Infra people have commit rights to the GitHub project. The Kafka committers push to the Apache Git repo and that gets synced automatically to GitHub. My understanding is that there is a desire to avoid a situation where people can push directly to GitHub for provenance reasons (I do

Re: Pull-Requests not worked on

2017-06-19 Thread Jeff Widman
On Thu, Jun 8, 2017 at 5:00 PM, Ismael Juma wrote: > One of the reasons why some PRs remain open even if they should be > closed is that we have no way to close PRs ourselves without referencing > them in a commit or asking Apache Infra for help. So, abandoned PRs tend to > remain open. This is v

Re: Pull-Requests not worked on

2017-06-08 Thread Ismael Juma
Hi all, A few clarifications: 1. Anyone can see the console output for a failed job, a login is not required for that. 2. One of the reasons why some PRs remain open even if they should be closed is that we have no way to close PRs ourselves without referencing them in a commit or asking Apache

Re: Pull-Requests not worked on

2017-06-08 Thread James Cheng
I always thought that we had to repush a commit or close/open the PR in order to retrigger the build. This is the first time I've heard that you can do that. Does "retest this please" cause the tests to be re-run, simply because it's a comment on a PR? Or is it some magic with how we set things

Re: Pull-Requests not worked on

2017-06-08 Thread Colin McCabe
So, there has been some instability in the junit tests recently due to some big features landing. This is starting to improve a lot, though, so hopefully it won't be a problem for much longer. If you do hit what you think is a bogus unit test failure, you can type "retest this please" in the PR t

Re: Pull-Requests not worked on

2017-05-23 Thread Jeff Widman
I agree with this. As a new contributor, it was a bit demoralizing to look at all the open PR's and wonder whether when I sent a patch it would just be left to sit in the ether. In other projects I'm involved with, more typically the maintainers go through periodically and close old PR's that will

Pull-Requests not worked on

2017-05-23 Thread marc . schlegel
Hello everyone I am wondering how pull-requests are handled for Kafka? There is currently a huge amount of PRs on Github and most of them are not getting any attention. If the maintainers only have a look at PR which passed the CI (which makes sense due to the amount), then there is a problem,