Re: Provide clients Header implementation without accessing internal package

2018-09-05 Thread Dongjin Lee
FYI: This discussion is initiated from this PR: https://github.com/apache/spark/pull/22282#discussion_r214632570 (Supporting Kafka Headers functionality in Spark Structured Streaming) Thanks, Dongjin On Wed, Sep 5, 2018 at 7:41 AM Jungtaek Lim wrote: > Hi Kafka devs, > > I just noticed that the

Provide clients Header implementation without accessing internal package

2018-09-04 Thread Jungtaek Lim
Hi Kafka devs, I just noticed that the only implementation for org.apache.kafka.common.header.Header is RecordHeader which is exposed to the 'internal' package, and some of end users just picked the class because they don't want to create their own. IMHO it can give false signal for end users on t