From: John Roesler
Sent: Tuesday, December 17, 2019 5:17 PM
To: dev@kafka.apache.org
Subject: Re: Proposal for EmbeddedKafkaCluster: Support JUnit 5 Extension in
addition to JUnit 4 Rule
Hi Tommy and Matthias,
Thanks for the context! I can see that there are good reasons to want a
supported
Hi Tommy and Matthias,
Thanks for the context! I can see that there are good reasons to want a
supported, embedded Kafka cluster. If you want to propose to add one, I can
help you navigate the process.
Thanks,
John
On Tue, Dec 10, 2019, at 07:13, Matthias Merdes wrote:
> Hi John and Thomas,
>
Hi John and Thomas,
Thanks a lot for your detailed and well-informed replies.
I am adding some comments below.
On 6. Dec 2019, at 17:42, John Roesler
mailto:vvcep...@apache.org>> wrote:
Hi Matthias!
Thanks for the note, and the kind sentiment.
We're always open to improvements like this, so
Thanks for the response John. I should point out that for streams app testing,
we generally do use the TopologyTestDriver and it is much appreciated. We use
EmbeddedKafkaCluster more for testing code that uses the Producer/Consumer
clients.
Regarding using something like maven-exec, I'm just no
Hi Tommy,
There are some practically ancient discussions around doing this exact thing,
but they haven't generally come to fruition because EmbeddedKafkaCluster itself
isn't really a slam dunk, usability-wise. You'll notice that copying it (i.e.,
using it _at all_ ) is the option of last resort
Personally, I would love to see EmbeddedKafkaCluster moved to a public test
artifact, similarly to kafka-streams-test-utils. Having to copy/paste internal
classes into your project is...unfortunate.
On Fri, 2019-12-06 at 10:42 -0600, John Roesler wrote:
[EXTERNAL EMAIL] Attention: This email w
Hi Matthias!
Thanks for the note, and the kind sentiment.
We're always open to improvements like this, so your contribution would
certainly be welcome.
Just FYI, "public interface" changes need to go through the KIP process (see
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improveme
Hi all,
when reading ‘Kafka Streams in Action’ I especially enjoyed the thoughtful
treatment of
mocking, unit, and integration tests.
Integration testing in the book (and in the Kafka codebase) is done using the
@ClassRule-annotated EmbeddedKafkaCluster.
JUnit 5 Jupiter replaced Rules with a dif
