Re: Patch for mmap + windows

2013-09-09 Thread Jay Kreps
I think Srirams complaint is that I haven't yet addressed his concerns :-) Sent from my iPhone On Sep 9, 2013, at 3:56 PM, Sriram Subramanian wrote: > I did take a look at KAFKA-1008 a while back and added some comments. > > On 9/9/13 3:52 PM, "Jay Kreps" wrote: > >> Cool can we get a revie

Re: Patch for mmap + windows

2013-09-09 Thread Timothy Chen
Hi Sriram, If Elizabeth isn't able to respond to your feedback, I wonder if you can fix the patch and apply it? It will be great to have this patch in 0.8. Thanks, Tim On Mon, Sep 9, 2013 at 3:56 PM, Sriram Subramanian < srsubraman...@linkedin.com> wrote: > I did take a look at KAFKA-1008 a

Re: Patch for mmap + windows

2013-09-09 Thread Sriram Subramanian
I did take a look at KAFKA-1008 a while back and added some comments. On 9/9/13 3:52 PM, "Jay Kreps" wrote: >Cool can we get a reviewer for KAFKA-1008 then? I can take on the other >issue for the checkpoint files. > >-Jay > > >On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede >wrote: > >> +1 for win

Re: Patch for mmap + windows

2013-09-09 Thread Jay Kreps
Cool can we get a reviewer for KAFKA-1008 then? I can take on the other issue for the checkpoint files. -Jay On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede wrote: > +1 for windows support on 0.8 > > Thanks, > Neha > > > On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps wrote: > > > So guys, do we want

Re: Patch for mmap + windows

2013-09-09 Thread Neha Narkhede
+1 for windows support on 0.8 Thanks, Neha On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps wrote: > So guys, do we want to do these in 0.8? The first patch was a little > involved but I think it would be good to have windows support in 0.8 and it > sounds like Tim is able to get things working afte

Re: Patch for mmap + windows

2013-09-09 Thread Jay Kreps
So guys, do we want to do these in 0.8? The first patch was a little involved but I think it would be good to have windows support in 0.8 and it sounds like Tim is able to get things working after these changes. -Jay On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen wrote: > Btw, I've been running

Re: Patch for mmap + windows

2013-09-09 Thread Timothy Chen
Btw, I've been running this patch in our cloud env and it's been working fine so far. I actually filed another bug as I saw another problem on windows locally ( https://issues.apache.org/jira/browse/KAFKA-1036). Tim On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps wrote: > That would be great! > >

Re: Patch for mmap + windows

2013-08-21 Thread Jay Kreps
That would be great! -Jay On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen wrote: > Hi Jay, > > I'm planning to test run Kafka on Windows in our test environments > evaluating if it's suitable for production usage. > > I can provide feedback with the patch how well it works and if we encounter >

Re: Patch for mmap + windows

2013-08-21 Thread Timothy Chen
Hi Jay, I'm planning to test run Kafka on Windows in our test environments evaluating if it's suitable for production usage. I can provide feedback with the patch how well it works and if we encounter any functional or perf problems. Tim On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps wrote: >

Patch for mmap + windows

2013-08-21 Thread Jay Kreps
Elizabeth and I have a patch to support our memory mapped offset index files properly on Windows: https://issues.apache.org/jira/browse/KAFKA-1008 Question: Do we want this on 0.8 or trunk? I would feel more comfortable with it in trunk, but that means windows support in 0.8 is known to be broken