Re: New consumer plans

2015-01-22 Thread Guozhang Wang
I have made a pass over the patch, the changes in NetworkClient / Selector / Sender look good to me. But there is one issue I found in the KafkaConsumer implementation, that when consumer subscribe (topic-partition), it will not send a join-group request to the coordinator. This seems to be differ

New consumer plans

2015-01-20 Thread Jay Kreps
There is a draft patch for the new consumer up on KAFKA-1760: https://issues.apache.org/jira/browse/KAFKA-1760 I chatted with Guozhang earlier today and here was our thought on how to proceed: 1. There are changes to NetworkClient and Sender that I'll describe below. These should be closely rev