Ok, last update (for now)
We merged https://github.com/apache/kafka/pull/18449 which changes PRs to
build the PR's HEAD commit instead of the merge ref.
This should help improve our cache hits in PR builds. To really benefit
from this, I'd encourage you to use the "committer-tools/update-cache.sh
Another thing that changed this week is the addition of a PR Linter. This
is part of the merge queue effort.
With merge queues, we cannot alter the commit message like we do with the
merge button. Instead the commit message comes from the PR title and PR
body. A script for validating the PR title+
Sophie,
> are tests automatically sorted into these buckets or do we have to
manually move them
This part hasn't changed -- we still need to manually mark tests as @Flaky
when they are flaky. The recent change has just separated out the flaky
tests into a parallel job rather than a sequential ste
Thanks David! This is awesome, really glad to see this effort to reduce
test flakiness.
One question -- are tests automatically sorted into these buckets or do we
have to manually move them? And if so, how does that work (eg a test in
"main" becomes flaky)
On Tue, Feb 25, 2025 at 3:20 PM David Ar
> Can we merge the PR if only flaky or new tests fail?
I agree with Ismael that new tests must be solid -- no flakiness should be
expected when adding a test. Obviously, we will miss things, so we have to
tolerate them on trunk (along with environmental flaky factors).
If there are existing *unre
>
> Can we merge the PR if only flaky or new tests fail?
We certainly cannot merge if new tests fail - the goal is to ensure new
tests are solid.
For the flaky ones, I'm not sure how we intend to use these. I would prefer
if we only merge when the PR status is green. Otherwise, we often end up
m
Thanks David - this is another important improvement to our CI pipeline and
is super helpful for the project and community.
Ismael
On Mon, Feb 24, 2025 at 2:15 PM David Arthur wrote:
> Hey everyone, just wanted to inform you all that we just merged KAFKA-18748
>
> https://github.com/apache/kafk
hi David
Thanks for all your improvement. I do love the new test suites!
one small question:
Can we merge the PR if only flaky or new tests fail? Sometimes, I list
tickets for flaky (or unrelated) tests before merging. However, since we
now have a separate test suite for stable tests (non-flaky,
Hey everyone, just wanted to inform you all that we just merged KAFKA-18748
https://github.com/apache/kafka/pull/18770
This splits our CI workflow into more parallel jobs which run subsets of
the tests with different settings. The JUnit tests are now split into
"new", "flaky", and the remainder.
