Yes, all changes are related to metric names. Feel free to review the patch.
Thanks,
Jun
On Fri, Oct 31, 2014 at 10:48 AM, Joel Koshy wrote:
> That sounds good, although is that the only change (sorry I have not
> done a careful review of that patch and would like to before it gets
> checked i
That sounds good, although is that the only change (sorry I have not
done a careful review of that patch and would like to before it gets
checked in).
On Fri, Oct 31, 2014 at 10:42:13AM -0700, Jun Rao wrote:
> To circle back on this thread. The patch in kafka-1482 is almost ready. To
> make the mb
To circle back on this thread. The patch in kafka-1482 is almost ready. To
make the mbean names more meaningful and easier to parse, the patch will
use explicit key/value pairs in the mbean name for things like clientId and
topic, and will get rid of the quotes.
So, instead of
"kafka.server":ty
Hi Jun,
On Wed, Sep 17, 2014 at 12:35 PM, Jun Rao wrote:
> Bhavesh,
>
> Yes, allowing dot in clientId and topic makes it a bit harder to define the
> JMX bean names. I see a couple of solutions here.
>
> 1. Disable dot in clientId and topic names. The issue is that dot may
> already be used in e
Sure we can do the option 2 for JMX beans. But same solution should be
applied to producer.metrics() method for new producer. Regardless of
metric is access (JMX or via producer), it has to be consistent naming
convention.
For example, I get following metric name when my topic is "topic.dot". S
Bhavesh,
Yes, allowing dot in clientId and topic makes it a bit harder to define the
JMX bean names. I see a couple of solutions here.
1. Disable dot in clientId and topic names. The issue is that dot may
already be used in existing deployment.
2. We can represent the JMX bean name differently i
HI Otis,
What is migration path ? If topic with special chars exists already(
".","-","|" etc) in previous version of producer/consumer of Kafka, what
happens after the upgrade new producer or consumer (kafka version) ? Also,
in new producer API (Kafka Trunk), does this enforce the rule about c
Hi,
So maybe I should I should have asked the Q explicitly:
Could we commit the patch from
https://issues.apache.org/jira/browse/KAFKA-1481 now that, I hope, it's
clear what problems the current MBean names can cause?
Thanks,
Otis
--
Monitoring * Alerting * Anomaly Detection * Centralized Log Man
