Re: [DISCUSS] Kafka-Streams-Scala for Scala 3

2024-02-15 Thread Matthias Berndt
matthias.ber...@ttmzero.com>: > Hey Matthew, > > Kafka-Streams-Scala is an entirely separate codebase from Kafka Core, and > the fact that almost three years after the release of Scala 3 there is > still no release of Kafka-Streams-Scala for Scala 3 – even though the > required c

Re: [DISCUSS] Kafka-Streams-Scala for Scala 3

2024-02-13 Thread Matthias Berndt
Hey Matthew, Kafka-Streams-Scala is an entirely separate codebase from Kafka Core, and the fact that almost three years after the release of Scala 3 there is still no release of Kafka-Streams-Scala for Scala 3 – even though the required changes to the codebase are trivial – tells me that these

Re: [DISCUSS] Kafka-Streams-Scala for Scala 3

2024-02-13 Thread Matthew de Detrich
As added info on top of what Josep said, in the Scala space most OS software supports Scala 2.12/Scala 2.13 and Scala 3 but with Scala 2.12 specifically the Scala OS community itself wants to eventually have people to stop supporting it (it's in maintenance mode) so it makes sense to tie this into

Re: [DISCUSS] Kafka-Streams-Scala for Scala 3

2024-02-12 Thread Matthias Berndt
The additional load on the ASF's CI infrastructure may or may not be a problem, but either way I don't think it is to be addressed within the scope of this particular change. Best, Matthias Am Mo., 12. Feb. 2024 um 11:37 Uhr schrieb Josep Prat : > Hi Matthias, > If I understand it right (I'm not

Re: [DISCUSS] Kafka-Streams-Scala for Scala 3

2024-02-12 Thread Josep Prat
Hi Matthias, If I understand it right (I'm not an expert in CI infra), Kafka uses the ASF shared Jenkins, meaning this would potentially increase the time-to-built for the rest of the projects. Best, On Mon, Feb 12, 2024 at 11:30 AM Matthias Berndt < matthias.ber...@ttmzero.com> wrote: > Hey Jos

Re: [DISCUSS] Kafka-Streams-Scala for Scala 3

2024-02-12 Thread Matthias Berndt
Hey Josep, wouldn't it be possible to run this in a separate CI job that runs in parallel? Then it shouldn't take any longer than today – assuming enough CI resources are available. Best, Matthias Am Mo., 12. Feb. 2024 um 09:14 Uhr schrieb Josep Prat : > Hi Matthias, > > One of the problems of

Re: [DISCUSS] Kafka-Streams-Scala for Scala 3

2024-02-12 Thread Josep Prat
Hi Matthias, One of the problems of adding support for Scala 3 for the scala-streams submodule is that we would need to have another build run on CI (which is already extremely long). I guess we could restrict this only when having changes on the Stream module(s). If I remember it correctly, when

[DISCUSS] Kafka-Streams-Scala for Scala 3

2024-02-09 Thread Matthias Berndt
Hey there, I'd like to discuss a Scala 3 release of the Kafka-Streams-Scala library. As you might have seen already, I have recently created a ticket https://issues.apache.org/jira/browse/KAFKA-16237 and a PR https://github.com/apache/kafka/pull/15338 to move this forward. The changes required to

Re: Kafka-Streams-Scala for Scala 3

2024-02-09 Thread Josep Prat
Hi Matthias, Yes, it's just a matter of adding the [DISCUSS] prefix in the subject. By the way, I didn't say this won't need a KIP, just that I won't be pushing for it, but other maintainers might think it's needed. For the discuss thread, you should write down what changes in the build and what

Re: Kafka-Streams-Scala for Scala 3

2024-02-09 Thread Matthias Berndt
Hey Josep, I'm glad you agree that a KIP is not needed here, and I agree with you that how to publish these artifacts should be discussed with the Kafka team. In fact, this is what I created this thread for 😁 This is my first time contributing to Kafka, so I'm going to have to ask what a DISCUSS t

Re: Kafka-Streams-Scala for Scala 3

2024-02-09 Thread Josep Prat
Hi Matthias, It's not adding a new functionality but it's changing the way to generate artifacts. In the end we are talking about generating a new binary. I could live with not having a KIP, but a DISCUSS thread I think it's necessary. This signals the community members and maintainers that their

Re: Kafka-Streams-Scala for Scala 3

2024-02-09 Thread Matthias Berndt
Hi Matthias, Hi Josep, I'm afraid I can't do the KIP thing as the signup process for Apache Confluence requires sending me a password reset link via E-Mail and said E-Mail doesn't seem to reach me for some reason. I've contacted the Apache infrastructure team but haven't yet heard back from them.

Re: Kafka-Streams-Scala for Scala 3

2024-02-08 Thread Matthias J. Sax
Josep, thanks for helping with this. I was also thinking if we might need a KIP for this change. Since you had the same though, I would say, yes, let's do a KIP. @Matthias: can you prepare a KIP? You can read up on the details on the wiki page: https://cwiki.apache.org/confluence/display/KA

Re: Kafka-Streams-Scala for Scala 3

2024-02-08 Thread Matthias Berndt
Hey Josep et al, I've created a ticket regarding this. https://issues.apache.org/jira/browse/KAFKA-16237 All the best, Matthias Am Do., 8. Feb. 2024 um 11:42 Uhr schrieb Josep Prat : > > Go ahead and ask for a JIRA and Wiki account (Confluence). Let us know when > your accounts are created and w

[jira] [Created] (KAFKA-16237) Kafka-Streams-Scala for Scala 3

2024-02-08 Thread Matthias Berndt (Jira)
Matthias Berndt created KAFKA-16237: --- Summary: Kafka-Streams-Scala for Scala 3 Key: KAFKA-16237 URL: https://issues.apache.org/jira/browse/KAFKA-16237 Project: Kafka Issue Type: New

Re: Kafka-Streams-Scala for Scala 3

2024-02-08 Thread Josep Prat
Go ahead and ask for a JIRA and Wiki account (Confluence). Let us know when your accounts are created and we'll properly set them up so you can create and assign tickets to you. Best, On Thu, Feb 8, 2024 at 11:32 AM Matthias Berndt wrote: > Thanks Josep, I've applied for a JIRA account and addr

Re: Kafka-Streams-Scala for Scala 3

2024-02-08 Thread Matthias Berndt
Thanks Josep, I've applied for a JIRA account and addressed your review comments. Am Do., 8. Feb. 2024 um 09:19 Uhr schrieb Josep Prat : > > Hi Matthias, > > I think for this particular case it would be worth creating a JIRA ticket > for this as it's a new "feature". > Regarding the change itself,

Re: Kafka-Streams-Scala for Scala 3

2024-02-08 Thread Josep Prat
Hi Matthias, I think for this particular case it would be worth creating a JIRA ticket for this as it's a new "feature". Regarding the change itself, I think we need to clarify how the release process would work. Right now, the script `gradlewAll` is used (which basically runs the build with Scala

Re: Kafka-Streams-Scala for Scala 3

2024-02-07 Thread Matthias Berndt
Hi Matthias J., Hi Lucas, Hi Josep, Thank you for your encouraging responses regarding a Scala 3 port of Kafka-Streams-Scala, and apologies for the late response from my side. I have now created a PR to port Kafka-Streams-Scala to Scala 3 (while retaining support for 2.13 and 2.12). Almost no chan

Re: Kafka-Streams-Scala for Scala 3

2024-02-01 Thread Josep Prat
Hi, For reference, prior work on this: https://github.com/apache/kafka/pull/11350 https://github.com/apache/kafka/pull/11432 Best, On Thu, Feb 1, 2024, 15:55 Lucas Brutschy wrote: > Hi Matthiases, > > I know Scala 2 fairly well, so I'd be happy to review changes that add > Scala 3 support. How

Re: Kafka-Streams-Scala for Scala 3

2024-02-01 Thread Lucas Brutschy
Hi Matthiases, I know Scala 2 fairly well, so I'd be happy to review changes that add Scala 3 support. However, as Matthias S. said, it has to be driven by people who use Scala day-to-day, since I believe most Kafka Streams committers are working with Java. Rewriting the tests to not use Embedded

Re: Kafka-Streams-Scala for Scala 3

2024-01-31 Thread Matthias J. Sax
Thanks for raising this. The `kafka-streams-scala` module seems to be an important feature for Kafka Streams and I am generally in favor of your proposal to add Scala 3 support. However, I am personally no Scala person and it sounds like quite some overhead. If you are willing to drive and own

Kafka-Streams-Scala for Scala 3

2024-01-20 Thread Matthias Berndt
Hey there, I'd like to discuss a Scala 3 port of the kafka-streams-scala library. Currently, the build system is set up such that kafka-streams-scala and core (i. e. kafka itself) are compiled with the same Scala compiler versions. This is not an optimal situation because it means that a Scala 3 r