Re: KIP-560 Discuss

2020-07-06 Thread Boyang Chen
No worry! Could you address Matthias' comments in this mailing thread? Seems we still have some gaps. On Mon, Jul 6, 2020 at 7:14 AM Sang wn Lee wrote: > I'm sorry. > I just modified the KIP! > > On 2020/03/07 20:09:47, "Matthias J. Sax" wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: S

Re: KIP-560 Discuss

2020-07-06 Thread Sang wn Lee
I'm sorry. I just modified the KIP! On 2020/03/07 20:09:47, "Matthias J. Sax" wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Thanks for the KIP Sang! > > I have a couple of more comments about the wiki page: > > (1) The "Public Interface" section should only list the new stuff

Re: KIP-560 Discuss

2020-07-06 Thread Sang wn Lee
I'm sorry. I just modified the KIP. On 2020/05/26 20:11:46, Boyang Chen wrote: > Hey Sang, unfortunately we couldn't make it in 2.6. Do you still plan to > work on this KIP? > > On Thu, May 14, 2020 at 6:49 PM Boyang Chen > wrote: > > > Hey Sang, seems this thread has been quiet, are you stil

Re: KIP-560 Discuss

2020-05-26 Thread Boyang Chen
Hey Sang, unfortunately we couldn't make it in 2.6. Do you still plan to work on this KIP? On Thu, May 14, 2020 at 6:49 PM Boyang Chen wrote: > Hey Sang, seems this thread has been quiet, are you still working on this > KIP? > > On Sat, Mar 7, 2020 at 3:54 PM Matthias J. Sax > wrote: > >> Thank

Re: KIP-560 Discuss

2020-05-14 Thread Boyang Chen
Hey Sang, seems this thread has been quiet, are you still working on this KIP? On Sat, Mar 7, 2020 at 3:54 PM Matthias J. Sax wrote: > Thanks for the KIP Sang! > > I have a couple of more comments about the wiki page: > > (1) The "Public Interface" section should only list the new stuff. This >

Re: KIP-560 Discuss

2020-03-07 Thread Matthias J. Sax
Thanks for the KIP Sang! I have a couple of more comments about the wiki page: (1) The "Public Interface" section should only list the new stuff. This KIP does not change anything with regard to the existing options `--input-topic` or `--intermediate-topic` and thus it's just "noise" to have them

Re: KIP-560 Discuss

2020-03-07 Thread Matthias J. Sax
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Thanks for the KIP Sang! I have a couple of more comments about the wiki page: (1) The "Public Interface" section should only list the new stuff. This KIP does not change anything with regard to the existing options `--input-topic` or `--intermedia

Re: KIP-560 Discuss

2020-01-27 Thread Sang wn Lee
thank you John Roesle It is a good idea "—all-input-topics" I agree with you I'll update right away On 2020/01/24 14:14:17, "John Roesler" wrote: > Hi all, thanks for the explanation. I was also not sure how the kip would be > possible to implement. > > No that it does seem plausible, my

Re: KIP-560 Discuss

2020-01-24 Thread John Roesler
Hi all, thanks for the explanation. I was also not sure how the kip would be possible to implement. No that it does seem plausible, my only feedback is that the command line option could align better with the existing one. That is, the existing option is called “—input-topics”, so it seems lik

Re: KIP-560 Discuss

2020-01-23 Thread Boyang Chen
Thanks Sophie for the explanation! I read Sang's PR and basically he did exactly what you proposed (check it here in case I'm wrong). I think Sophie's response answers Gwen's question already, while in the meantime for a KIP itself we are not requi

Re: KIP-560 Discuss

2020-01-23 Thread Sophie Blee-Goldman
Hi all, I think what Gwen is trying to ask (correct me if I'm wrong) is how we can infer which topics are associated with Streams from the admin client's topic list. I agree that this doesn't seem possible, since as she pointed out the topics list (or even description) lacks the specific informati

Re: KIP-560 Discuss

2020-01-18 Thread Sang wn Lee
Thank you I understand you 1. admin client has topic list 2. applicationId can only have one stream, so It won't be a problem! 3. For example, --input-topic [reg] Allowing reg solves some inconvenience On 2020/01/18 18:15:23, Gwen Shapira wrote: > I am not sure I follow. Afaik: > > 1. Topic

Re: KIP-560 Discuss

2020-01-18 Thread Gwen Shapira
I am not sure I follow. Afaik: 1. Topics don't include client ID information 2. Even if you did, the same ID could be used for topics that are not Kafka Streams input The regex idea sounds doable, but I'm not sure it solves much? On Sat, Jan 18, 2020, 7:12 AM Sang wn Lee wrote: > Thank you >

Re: KIP-560 Discuss

2020-01-18 Thread Sang wn Lee
Thank you Gwen Shapira! We'll add a flag to clear all topics by clientId It is ‘reset-all-external-topics’ I also want to use regex on the input topic flag to clear all matching topics. On 2020/01/17 19:29:09, Gwen Shapira wrote: > Seem like a very nice improvement to me. But I have to admit th

Re: KIP-560 Discuss

2020-01-17 Thread Gwen Shapira
Seem like a very nice improvement to me. But I have to admit that I don't understand how this will how - how could you infer the input topics? On Thu, Jan 16, 2020 at 10:03 AM Sang wn Lee wrote: > > Hello, > > Starting this thread to discuss KIP-560: > wiki link : > https://cwiki.apache.org/confl

KIP-560 Discuss

2020-01-16 Thread Sang wn Lee
Hello, Starting this thread to discuss KIP-560: wiki link : https://cwiki.apache.org/confluence/display/KAFKA/KIP-560%3A+Auto+infer+external+topic+partitions+in+stream+reset+tool I'm newbie I would like to receive feedback on the following features!