Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-11-24 Thread Matthias J. Sax
Moved this KIP into status "inactive". Feel free to resume and any time. -Matthias On 6/27/19 4:37 PM, Richard Yu wrote: > Hi Matthias and Hachikuji, > Sorry for getting back to you so late. Currently on a trip, so I hadn't got > the time to respond. > Currently, I'm not sure which approach we

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-06-27 Thread Richard Yu
Hi Matthias and Hachikuji, Sorry for getting back to you so late. Currently on a trip, so I hadn't got the time to respond. Currently, I'm not sure which approach we should do ATM, considering that Guozhang posed multiple possibilities in the previous email.Do you have any preferences as to whi

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-06-13 Thread Richard Yu
Hi Guozhang, Thanks for the input! Then I guess from the approach you have listed above, no API changes will be needed in Kafka consumer then. That will greatly simplify things, although when implementing these approaches, there might be some unexpected issues which might show up. Cheers,Richar

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-06-12 Thread Guozhang Wang
Hi Richard, Sorry for getting late on this, I've finally get some time to take a look at https://github.com/apache/kafka/pull/6594 as well as the KIP itself. Here are some thoughts: 1. The main motivation of this KIP is to be able to distinguish the case where a. "Streams client is in an unhealt

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-28 Thread Richard Yu
Alright, I made some changes. Matthias, if you had time, it would be good if you made another pass. This should be close to completion. Cheers, Richard On Sat, Apr 27, 2019 at 3:46 PM Richard Yu wrote: > Hi Matthias, > > Sure, I could do the DISCONNECTED state. > > > On Sat, Apr 27, 2019 at 3:1

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-27 Thread Richard Yu
Hi Matthias, Sure, I could do the DISCONNECTED state. On Sat, Apr 27, 2019 at 3:16 PM Matthias J. Sax wrote: > Thanks for updating the KIP. I also had a quick look into your PR. > > I actually think that the original idea to add a new state DISCONNECTED > would provide a better user experience

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-27 Thread Matthias J. Sax
Thanks for updating the KIP. I also had a quick look into your PR. I actually think that the original idea to add a new state DISCONNECTED would provide a better user experience. Your current proposal does not add a new state, even if it mentions this in the beginning. Compare: https://github.com

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-23 Thread Richard Yu
Oh, so if possible. I thought it would be good if we could finish this KIP up. Matthias, or Michael, if you have any further comments, please let me know. :) Otherwise, I might restart the voting thread in a few days. Cheers, Richard On Wed, Apr 17, 2019 at 2:30 PM Richard Yu wrote: > Alright,

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-17 Thread Richard Yu
Alright, so I made a few changes to the KIP. I realized that there might be an easier way to give the user information on the connection state of Kafka Streams. In implementation, if one wishes to have DISCONNECTED as a state, then one would have to factor in proper state transitions. The other app

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-17 Thread Richard Yu
I just realized something. Hi Matthias, might need your input here. I realized that when implementing this change, as noted in the JIRA, we would need to "check the behaviour of the consumer" since its consumer's connection with broker that we are dealing with. So doesn't that mean we would also

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-17 Thread Richard Yu
Hi Micheal, Yeah, those are some points I should've clarified. No problem. Have got it done. On Wed, Apr 17, 2019 at 6:42 AM Michael Noll wrote: > Richard, > > thanks for looking into this! > > However, I have some concerns. The KIP you created ( > > https://cwiki.apache.org/confluence/displa

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-17 Thread Michael Noll
Richard, thanks for looking into this! However, I have some concerns. The KIP you created ( https://cwiki.apache.org/confluence/display/KAFKA/KIP-457%3A+Add+DISCONNECTED+status+to+Kafka+Streams) doesn't yet address open questions such as the ones mentioned by Matthias: 1) What is the difference

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-16 Thread Richard Yu
Hi all, Considering that this is a simple KIP, I would probably start the voting tomorrow. I think it would be good if we could get this in fast. On Tue, Apr 16, 2019 at 3:31 PM Richard Yu wrote: > Oh, I probably misunderstood the difference between DISCONNECTED and DEAD. > I will update the KI

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-16 Thread Richard Yu
Oh, I probably misunderstood the difference between DISCONNECTED and DEAD. I will update the KIP accordingly. Thanks for pointing that out! On Tue, Apr 16, 2019 at 3:13 PM Matthias J. Sax wrote: > Thanks for the initiative. > > In the motivation you mention that you want to use DISCONNECT to >

Re: KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-16 Thread Matthias J. Sax
Thanks for the initiative. In the motivation you mention that you want to use DISCONNECT to indicate that the application was killed. What is the difference to existing state DEAD? Also, the backing JIRA seems to have a different motivation to add a DISCONNECT state. There, the Kafka Streams app

KIP-457: Add DISCONNECTED state to Kafka Streams

2019-04-16 Thread Richard Yu
Hi all, I like to propose a small KIP on adding a new state to KafkaStreams#state(). It is very simple, so this should pass relatively quickly! Here is the discussion link: https://cwiki.apache.org/confluence/display/KAFKA/KIP-457%3A+Add+DISCONNECTED+status+to+Kafka+Streams Cheers, Richard