[jira] [Comment Edited] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934469#comment-13934469 ] korebantic2 edited comment on KAFKA-657 at 3/14/14 3:2

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934469#comment-13934469 ] korebantic2 commented on KAFKA-657: --- All, I'm looking to update a client t

Re: KAFKA-657

Hello Joe, On the Jira page, you can check to which branch it gets applied to by checking "Fix Version/s". Guozhang On Fri, Dec 6, 2013 at 6:15 AM, Joe Stein wrote: > That patch is only on the trunk, will be in 0.8.1 > > /*** > Joe Stein > Founder, Pr

Re: KAFKA-657

That patch is only on the trunk, will be in 0.8.1 /*** Joe Stein Founder, Principal Consultant Big Data Open Source Security LLC http://www.stealth.ly Twitter: @allthingshadoop ***

KAFKA-657

Can someone let me know if this patch made it into 0.8.0 Thanks Joe

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544370#comment-13544370 ] Jay Kreps commented on KAFKA-657: - I updated the property name. Normally I am aga

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544354#comment-13544354 ] David Arthur commented on KAFKA-657: Jun, 80. Those commented out tests wil

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544322#comment-13544322 ] Jun Rao commented on KAFKA-657: --- v8 looks good. Just some minor comments.

[jira] [Resolved] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-657. - Resolution: Fixed Fix Version/s: 0.8.1 Committed. > Add an API to commit offs

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544261#comment-13544261 ] Neha Narkhede commented on KAFKA-657: - +1 on v8 > Add an

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544054#comment-13544054 ] Jay Kreps commented on KAFKA-657: - This looks good to me. If no further objections

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-657: --- Attachment: KAFKA-657v8.patch Attaching v8 70. I have consolidated (offset, metadata, error) into a

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543459#comment-13543459 ] Jay Kreps commented on KAFKA-657: - Works for me. > Add an API to

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543448#comment-13543448 ] David Arthur commented on KAFKA-657: I have "offset.metadata.max.size"

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543277#comment-13543277 ] Jay Kreps commented on KAFKA-657: - Yeah that is the right place for a new config. I

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543227#comment-13543227 ] David Arthur commented on KAFKA-657: We had talked about limiting the size of

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542566#comment-13542566 ] Jay Kreps commented on KAFKA-657: - Looks good to me. A few things in addition to the o

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542540#comment-13542540 ] Jun Rao commented on KAFKA-657: --- Thanks for patch v7. Some more comments:

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-657: --- Attachment: KAFKA-657v7.patch Attaching patch v7 - addresses Joel's comments.

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542390#comment-13542390 ] Joel Koshy commented on KAFKA-657: -- Hey David, the patch (and the wiki) looks g

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542299#comment-13542299 ] David Arthur commented on KAFKA-657: Post-holiday bump. Anyone had a chance to loo

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-657: --- Attachment: KAFKA-657v6.patch Finally figured out what you guys meant by adding error handling to the

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539141#comment-13539141 ] Neha Narkhede commented on KAFKA-657: - +1 on v5. Just a minor comment which I t

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-657: --- Attachment: KAFKA-657v5.patch Attaching patch v5. Added ASL header and javaapi. Not really sure how

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537390#comment-13537390 ] Jay Kreps commented on KAFKA-657: - Also I had one more generalization I would like to

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537368#comment-13537368 ] Jay Kreps commented on KAFKA-657: - It probably makes sense to do this in two phases. L

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537327#comment-13537327 ] Jun Rao commented on KAFKA-657: --- Thanks for patch v4. Some comments: 40. Could you add

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-657: --- Attachment: KAFKA-657v4.patch I regenerated the patch after rebasing from trunk. Jun, see if it works

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537237#comment-13537237 ] Jun Rao commented on KAFKA-657: --- I was trying to apply patch v3 in trunk (on a revi

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537062#comment-13537062 ] David Arthur commented on KAFKA-657: Jay, the one thing I'm still unclear o

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-657: --- Attachment: KAFKA-657v3.patch v3 of the patch 1. info -> debug 2. catching general exceptions

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534233#comment-13534233 ] Jay Kreps commented on KAFKA-657: - Makes sense. The API is versioned so we can always

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534178#comment-13534178 ] David Arthur commented on KAFKA-657: Yes, they are somewhat orthogonal. The only

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534162#comment-13534162 ] Jay Kreps commented on KAFKA-657: - I think that actually covers an orthogonal pro

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534151#comment-13534151 ] David Arthur commented on KAFKA-657: Re 3: Maybe this is a case for the check-and

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534122#comment-13534122 ] Jay Kreps commented on KAFKA-657: - This looks great! Three minor things: 1. Can

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-657: --- Attachment: KAFKA-657v2.patch v2 of the patch. Includes OffsetFetch and OffsetCommit APIs, some unit

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530700#comment-13530700 ] Jay Kreps commented on KAFKA-657: - I wonder if you could take a look at the updated

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530174#comment-13530174 ] David Arthur commented on KAFKA-657: Thanks [~jkreps], that clears things up qui

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529617#comment-13529617 ] Jay Kreps commented on KAFKA-657: - The existing API describes the offset ranges conta

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529613#comment-13529613 ] David Arthur commented on KAFKA-657: I'm fine working on the rest of 1. 1a

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529589#comment-13529589 ] Jay Kreps commented on KAFKA-657: - Oh yes, two other things: 1. We don't have a

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529583#comment-13529583 ] Jay Kreps commented on KAFKA-657: - This looks great. To confirm, the final format for

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-657: --- Attachment: KAFKA-657v1.patch First pass at adding a commit offset request > Add

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526687#comment-13526687 ] David Arthur commented on KAFKA-657: I have started a wiki page for this de

[jira] [Updated] (KAFKA-657) Add an API to commit offsets

[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-657: Labels: project (was: ) > Add an API to commit offs

[jira] [Created] (KAFKA-657) Add an API to commit offsets

Jay Kreps created KAFKA-657: --- Summary: Add an API to commit offsets Key: KAFKA-657 URL: https://issues.apache.org/jira/browse/KAFKA-657 Project: Kafka Issue Type: New Feature Reporter