Re: Do not log value of configs that Kafka doesn't recognize

2016-08-17 Thread Jaikiran Pai
Created https://issues.apache.org/jira/browse/KAFKA-4056. -Jaikiran On Wednesday 17 August 2016 06:28 PM, Ismael Juma wrote: Yes, please file a JIRA. Thanks, Ismael On Wed, Aug 17, 2016 at 1:46 PM, Jaikiran Pai wrote: Thanks for the inputs. I think it's fine if Kafka selectively logs val

Re: Do not log value of configs that Kafka doesn't recognize

2016-08-17 Thread Ismael Juma
Yes, please file a JIRA. Thanks, Ismael On Wed, Aug 17, 2016 at 1:46 PM, Jaikiran Pai wrote: > Thanks for the inputs. > > I think it's fine if Kafka selectively logs values for certain configs and > masks others (the passwords). So from what I understand, this looks more > like a bug where it u

Re: Do not log value of configs that Kafka doesn't recognize

2016-08-17 Thread Jaikiran Pai
Thanks for the inputs. I think it's fine if Kafka selectively logs values for certain configs and masks others (the passwords). So from what I understand, this looks more like a bug where it unintentionally ended up logging these values. Do you want me to file a JIRA for this? -Jaikiran On

Re: Do not log value of configs that Kafka doesn't recognize

2016-08-17 Thread Ismael Juma
Note that we already mask password related config values[1]. The issue is that it only happens after parsing, and the output of `logUnused` is based on the `originals` map, which has the values before parsing: public void logUnused() { for (String key : unused()) log.warn("The

Re: Do not log value of configs that Kafka doesn't recognize

2016-08-17 Thread Manikumar Reddy
During server/client startup, we are logging all the supplied configs. May be we can just mask the password related config values for both valid/invalid configs. On Wed, Aug 17, 2016 at 5:14 PM, Jaikiran Pai wrote: > Any opinion about this proposed change? > > -Jaikiran > > On Tuesday 16 August

Re: Do not log value of configs that Kafka doesn't recognize

2016-08-17 Thread Jaikiran Pai
Any opinion about this proposed change? -Jaikiran On Tuesday 16 August 2016 02:28 PM, Jaikiran Pai wrote: We are using 0.9.0.1 of Kafka (Java) libraries for our Kafka consumers and producers. In one of our consumers, our consumer config had a SSL specific property which ended up being used agai

Do not log value of configs that Kafka doesn't recognize

2016-08-16 Thread Jaikiran Pai
We are using 0.9.0.1 of Kafka (Java) libraries for our Kafka consumers and producers. In one of our consumers, our consumer config had a SSL specific property which ended up being used against a non-SSL Kafka broker port. As a result, the logs ended up seeing messages like: 17:53:33,722 WARN