Re: Contribution help please

2021-09-20 Thread Luke Chen
Hi Jon, I checked your PR. I think you didn't set the "indent" correctly. It looks like your indent setting is to 2, but we use 4. Please update the setting in IntelliJ. REF: https://www.jetbrains.com/help/idea/reformat-and-rearrange-code.html Thank you. Luke On Mon, Sep 20, 2021 at 2:47 PM Jon M

Contribution help please

2021-09-19 Thread Jon McEwen
Hello Kafka folks, Could somone please tell me how to correctly format kafka Java code? Either on command line or in IntelliJ. I'm working on KAFKA-13303. Many thanks Jon McEwen https://github.com/jonmcewen

Re: Contribution help please

2021-09-19 Thread Boyang Chen
Have you checked out https://kafka.apache.org/coding-guide? On Fri, Sep 17, 2021 at 7:12 AM Jon McEwen wrote: > Hello Kafka folks, > > Could somone please tell me how to correctly format kafka Java code? > Either on command line or in IntelliJ. > > Many thanks > > Jon McEwen > > https://github.c

Contribution help please

2021-09-17 Thread Jon McEwen
Hello Kafka folks, Could somone please tell me how to correctly format kafka Java code? Either on command line or in IntelliJ. Many thanks Jon McEwen https://github.com/jonmcewen