Re: ConsumerTest

2015-02-27 Thread Neha Narkhede
Sounds good. Thanks! On Fri, Feb 27, 2015 at 3:01 PM, Guozhang Wang wrote: > Thanks Neha, I will make sure the ConsumerTest gets fixed when I check in > 1910. > > On Fri, Feb 27, 2015 at 2:12 PM, Neha Narkhede wrote: > > > Thanks for the quick responses. I deleted it for

Re: ConsumerTest

2015-02-27 Thread Guozhang Wang
Thanks Neha, I will make sure the ConsumerTest gets fixed when I check in 1910. On Fri, Feb 27, 2015 at 2:12 PM, Neha Narkhede wrote: > Thanks for the quick responses. I deleted it for now, since commenting out > code is silly given that you can revive the file from version control &

Re: ConsumerTest

2015-02-27 Thread Neha Narkhede
Thanks for the quick responses. I deleted it for now, since commenting out code is silly given that you can revive the file from version control later. On Fri, Feb 27, 2015 at 2:03 PM, Joel Koshy wrote: > +1 > > On Fri, Feb 27, 2015 at 01:50:07PM -0800, Neha Narkhede wrote: > > Wow. That was qui

Re: ConsumerTest

2015-02-27 Thread Joel Koshy
+1 On Fri, Feb 27, 2015 at 01:50:07PM -0800, Neha Narkhede wrote: > Wow. That was quick :-) > Any committers who would also like to give a +1? > > On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh wrote: > > > +1 > > > > On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira > > wrote: > > > > > Actually,

Re: ConsumerTest

2015-02-27 Thread Neha Narkhede
Wow. That was quick :-) Any committers who would also like to give a +1? On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh wrote: > +1 > > On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira > wrote: > > > Actually, we will greatly appreciate :) > > > > On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede > w

Re: ConsumerTest

2015-02-27 Thread Ashish Singh
+1 On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira wrote: > Actually, we will greatly appreciate :) > > On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede wrote: > > Would anyone object if I commented out the kafka.api.ConsumerTest out > until > > it is fixed? It hangs and is making accepting patches

Re: ConsumerTest

2015-02-27 Thread Jiangjie Qin
+1 On 2/27/15, 1:41 PM, "Harsha" wrote: >+1 > >On Fri, Feb 27, 2015, at 01:37 PM, Neha Narkhede wrote: >> Would anyone object if I commented out the kafka.api.ConsumerTest out >> until >> it is fixed? It hangs and is making accepting patches very >> time-consuming. >> >> -- >> Thanks, >> Neha

Re: ConsumerTest

2015-02-27 Thread Gwen Shapira
Actually, we will greatly appreciate :) On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede wrote: > Would anyone object if I commented out the kafka.api.ConsumerTest out until > it is fixed? It hangs and is making accepting patches very time-consuming. > > -- > Thanks, > Neha

Re: ConsumerTest

2015-02-27 Thread Harsha
+1 On Fri, Feb 27, 2015, at 01:37 PM, Neha Narkhede wrote: > Would anyone object if I commented out the kafka.api.ConsumerTest out > until > it is fixed? It hangs and is making accepting patches very > time-consuming. > > -- > Thanks, > Neha

ConsumerTest

2015-02-27 Thread Neha Narkhede
Would anyone object if I commented out the kafka.api.ConsumerTest out until it is fixed? It hangs and is making accepting patches very time-consuming. -- Thanks, Neha