Yes, this is actually indeed an incompatible change.
In 0.8.1.x, ConsumerConnector has the following api:
def commitOffsets
This is changed to the following in 0.8.2 and breaks compatibility
def commitOffsets(retryOnFailure: Boolean = true)
Filed KAFKA-1743 as an 0.8.2 blocker.
Thanks,
Jun
On Thu, Oct 30, 2014 at 9:20 AM, Jay Kreps
mailto:jay.kr...@gmail.com>> wrote:
I think we should treat this like a bug for 0.8.2 final, we should be able
to add two commitOffsets methods with and without the param which should
fix the problem, right?
On Oct 30, 2014, at 9:51 AM, Jun Rao
mailto:j
Yes, we can change this to two methods in 0.8.2 final.
Thanks,
Jun
On Thu, Oct 30, 2014 at 9:20 AM, Jay Kreps wrote:
> But Jun,
>
> That change breaks peoples code who weren't calling in that way. I don't
> think we should be making breaking changes in a point release like this.
>
> I think we
+1 on two methods
--
Colin Clark
+1-320-221-9531
> On Oct 30, 2014, at 11:24 AM, Jonathan Weeks wrote:
>
> +1 on the two methods suggestion
>
> -JW
>
>> On Oct 30, 2014, at 9:20 AM, Jay Kreps wrote:
>>
>> But Jun,
>>
>> That change breaks peoples code who weren't calling in that way. I
+1 on the two methods suggestion
-JW
On Oct 30, 2014, at 9:20 AM, Jay Kreps wrote:
> But Jun,
>
> That change breaks peoples code who weren't calling in that way. I don't
> think we should be making breaking changes in a point release like this.
>
> I think we should treat this like a bug for
But Jun,
That change breaks peoples code who weren't calling in that way. I don't
think we should be making breaking changes in a point release like this.
I think we should treat this like a bug for 0.8.2 final, we should be able
to add two commitOffsets methods with and without the param which s
Jack,
The commit offset api is changed slightly from
def commitOffsets() in 0.8.1.x
to
def commitOffsets(retryOnFailure: Boolean = true) in 0.8.2.x.
If you have been calling the method with parentheses like commitOffsets(),
then the code will compile in both 0.8.1.x and 0.8.2.x. In general, th
Scala 2.10.4, kafka 0.8.1.1, my old code - compiled
Scala 2.10.4, kafka 0.8.2, my old code - failed
If that's the case, then we probably need to fix the issue. Can you please
file a JIRA?
On Wed, Oct 29, 2014 at 3:15 PM, Jack Foy wrote:
> On Oct 29, 2014, at 3:03 PM, Jack Foy wrote:
> > On Oct
On Oct 29, 2014, at 3:03 PM, Jack Foy wrote:
> On Oct 29, 2014, at 1:46 PM, Neha Narkhede wrote:
>> Which version of Scala did you use for Kafka 0.8.2-beta?
>
> The problem reproduces under both Scala 2.10.4 and Scala 2.11.2.
Sorry, to be clearer:
I am using SBT with the following dependency
On Oct 29, 2014, at 1:46 PM, Neha Narkhede wrote:
> Which version of Scala did you use for Kafka 0.8.2-beta?
The problem reproduces under both Scala 2.10.4 and Scala 2.11.2.
--
Jack Foy
Which version of Scala did you use for Kafka 0.8.2-beta?
On Wed, Oct 29, 2014 at 12:40 PM, Jack Foy wrote:
> My Scala project built against kafka 0.8.1.1 commits consumer offsets as
> follows:
>
> connector.commitOffsets
>
> This compiles without warnings. When I bumped the library dependenc
My Scala project built against kafka 0.8.1.1 commits consumer offsets as
follows:
connector.commitOffsets
This compiles without warnings. When I bumped the library dependency to
0.8.2-beta, the compiler started emitting this error:
[error] src/main/scala/com/whitepages/kafka/consumer/C
12 matches
Mail list logo
