Re: ClientsMetricsTest.shouldAddCommitIdMetric() failed on RC0 ...

2019-11-19 Thread Eric Lalonde
I see, thanks Bruno. > On Nov 19, 2019, at 12:24 AM, Bruno Cadonna wrote: > > Hi Eric, > > With archive of the release candidate I mean: > > https://home.apache.org/~manikumar/kafka-2.4.0-rc0/kafka-2.4.0-src.tgz > or > https://github.com/apache/kafka/archive/2.4.0-rc0.zip > or > https://git

Re: ClientsMetricsTest.shouldAddCommitIdMetric() failed on RC0 ...

2019-11-19 Thread Bruno Cadonna
Hi Eric, With archive of the release candidate I mean: https://home.apache.org/~manikumar/kafka-2.4.0-rc0/kafka-2.4.0-src.tgz or https://github.com/apache/kafka/archive/2.4.0-rc0.zip or https://github.com/apache/kafka/archive/2.4.0-rc0.tar.gz If you used one of those and you ran into the failure

Re: ClientsMetricsTest.shouldAddCommitIdMetric() failed on RC0 ...

2019-11-18 Thread Eric Lalonde
Bruno, I tested using the 2.4.0 release candidate 0 artifacts. These were uploaded as part of seeking the open Kafka community feedback. On Mon, Nov 18, 2019 at 12:24 PM Bruno Cadonna wrote: > Hi Vahid and Eric, > > Thank you for your input. > > I suppose you both used the archive of the releas

ClientsMetricsTest.shouldAddCommitIdMetric() failed on RC0 ...

2019-11-18 Thread Bruno Cadonna
Hi Vahid and Eric, Thank you for your input. I suppose you both used the archive of the release candidate and did not checkout the tag from the git repository. I found the issue. The archive misses the .git directory that is needed for the unit test to pass. Opened the following PR to fix it: h