+1 from me, though I did submit the patch
On 12/13/12 1:40 AM, Joe Stein wrote:
+1 on the code change looks alright, I prefer using the java version in
this case only because we are using an implementation from another project
and its a drop in ... no reason to change things without good reason,
+1 on the code change looks alright, I prefer using the java version in
this case only because we are using an implementation from another project
and its a drop in ... no reason to change things without good reason, yup.
On Wed, Dec 12, 2012 at 11:55 PM, Jay Kreps wrote:
> This patch is pretty
This patch is pretty safe, I did a pretty serious test against the java
impl on millions of crcs. The code change is just a few lines. I would like
to get this on trunk. Review?
https://issues.apache.org/jira/browse/KAFKA-374
Also, do folks have a preference between the java and scala version?
-
