Re: Action requested: Changes to CI for JDK 11 & 17 builds on Pull Requests

2024-05-30 Thread Ismael Juma
To clarify, when you build with Java 21 and pass "--release 8" (like we do), it's the same as building with Java 8. That's why compiling with a specific version doesn't actually help (unlike running with multiple versions). Ismael On Mon, May 27, 2024, 11:36 PM Luke Chen wrote: > > I did not se

Re: Action requested: Changes to CI for JDK 11 & 17 builds on Pull Requests

2024-05-28 Thread Luke Chen
Wow! I've never seen this beautiful green on jenkins for years! Thanks Greg!! Luke On Tue, May 28, 2024 at 4:12 PM Chia-Ping Tsai wrote: > Please take a look at following QA. ALL PASS!!! > > > https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15889/25/pipeline >

Re: Action requested: Changes to CI for JDK 11 & 17 builds on Pull Requests

2024-05-28 Thread Chia-Ping Tsai
Please take a look at following QA. ALL PASS!!! https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15889/25/pipeline I almost cried, and BIG thanks to Harris!!! On 2024/05/28 03:20:01 Greg Harris wrote: > Hello Apache Kafka Developers, > > In order to better util

Re: Action requested: Changes to CI for JDK 11 & 17 builds on Pull Requests

2024-05-27 Thread Luke Chen
> I did not see build failure that happens in 11 and 17 but not in 8 or 21, and also it can save more CI resources and make our CI be thinner. Same here. I've never seen build passed in jdk 21 but failed in 11 or 17. But even if it happened, it is rare. I think we are just making a trade-off to mak

Re: Action requested: Changes to CI for JDK 11 & 17 builds on Pull Requests

2024-05-27 Thread Chia-Ping Tsai
Dear all, I do love Harris's patch as no one love slow CI I believe. For another, I file https://issues.apache.org/jira/browse/KAFKA-16847 just now to revise our readme about JDK. I'd like to raise more discussion here. > Note that compilation with Java 11/17 doesn't add any value over compili

Re: Action requested: Changes to CI for JDK 11 & 17 builds on Pull Requests

2024-05-27 Thread Ismael Juma
Hi Greg, Thanks for making this change. Note that compilation with Java 11/17 doesn't add any value over compiling with Java 21 with the appropriate --release config (which we set). So, this part of the build process is wasteful. Running the tests does add some value (and hence why we originally