回复:回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-05-29 Thread feyman2009
. Please let me know if you have any concerns, thanks a lot! Feyman -- 发件人:feyman2009 发送时间:2020年4月13日(星期一) 08:47 收件人:dev 主 题:回复:回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

回复:回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-12 Thread feyman2009
Thanks , John and Guochang! -- 发件人:Guozhang Wang 发送时间:2020年4月11日(星期六) 03:07 收件人:dev 主 题:Re: 回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Thanks Feyman, I've looked at the update tha

Re: 回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-10 Thread Guozhang Wang
inding +1(Boyang, Sophie), I will mark it as > > approved and create a PR shortly. > > Thanks! > > > > Feyman > > ------ > > 发件人:feyman2009 > > 发送时间:2020年4月8日(星期三) 14:21 > > 收件人:

Re: 回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-10 Thread John Roesler
> 收件人:dev ; Boyang Chen > 主 题:回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove > members in StreamsResetter > > Hi Boyang, > Thanks for reminding me of that! > I'm not sure about the convention, I thought it would need to > re-collect votes if the

回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-09 Thread feyman2009
) 14:21 收件人:dev ; Boyang Chen 主 题:回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Hi Boyang, Thanks for reminding me of that! I'm not sure about the convention, I thought it would need to re-collect votes if the KIP has changed~ Let's

回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread feyman2009
ks! Feyman -- 发件人:Boyang Chen 发送时间:2020年4月8日(星期三) 12:42 收件人:dev ; feyman2009 主 题:Re: 回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter You should already get enough votes if I'm counting corr

Re: 回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread Boyang Chen
gt; >> 发件人:Boyang Chen > > >> 发送时间:2020年3月29日(星期日) 01:45 > > >> 收件人:dev ; feyman2009 > > >> 主 题:Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in > > StreamsResetter > > >> > > >> Hey Feyman, > > >> > > >> thanks for the update. I assume we would rely entirely on the in

回复:回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread feyman2009
s! Feyman -- 发件人:Boyang Chen 发送时间:2020年4月8日(星期三) 02:15 收件人:dev 主 题:Re: 回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Hey Feyman, I think Matthias' suggestion is optional, and we could just use admin tool to remove single static m

Re: 回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread Boyang Chen
Would you mind to elaborate why we still need that if we are > able to batch remove active members with adminClient? > > > > Thanks! > > > > Feyman > > ------------------ > > 发件人:Matthias J. Sax > > 发送时间:2020年4月7日(星期二) 08:25

Re: 回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread Matthias J. Sax
members with adminClient? > > Thanks! > > Feyman > -- > 发件人:Matthias J. Sax > 发送时间:2020年4月7日(星期二) 08:25 > 收件人:dev > 主 题:Re: 回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in > StreamsReset

回复:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-07 Thread feyman2009
man -- 发件人:Matthias J. Sax 发送时间:2020年4月7日(星期二) 08:25 收件人:dev 主 题:Re: 回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Overall LGTM. +1 (binding) So you do not plan so support removing a _single static_ member

Re: 回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-04-06 Thread Matthias J. Sax
间:2020年3月29日(星期日) 01:45 > 收件人:dev ; feyman2009 > 主 题:Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in > StreamsResetter > > Hey Feyman, > > thanks for the update. I assume we would rely entirely on the internal > changes for `removeMemberFromGroup` by

回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-30 Thread feyman2009
发件人:feyman2009 发送时间:2020年3月23日(星期一) 08:51 收件人:dev 主 题:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Hi, team I have updated the KIP-571 according to our latest discussion results, would you mind to take a look? Thanks! F

Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-28 Thread Boyang Chen
-- > 发件人:Boyang Chen > 发送时间:2020年3月19日(星期四) 13:41 > 收件人:dev ; feyman2009 > 主 题:Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in > StreamsResetter > > Thanks for the insight Feyman. I personally feel adding another a

回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-27 Thread feyman2009
Bump, can anyone kindly take a look at the updated KIP-571? Thanks! -- 发件人:feyman2009 发送时间:2020年3月23日(星期一) 08:51 收件人:dev 主 题:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Hi, team I have

回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-22 Thread feyman2009
I will update the KIP shortly! Thanks! Feyman -- 发件人:Boyang Chen 发送时间:2020年3月14日(星期六) 00:39 收件人:dev 主 题:Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Thanks Matthias and Guozhang

Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-18 Thread Boyang Chen
ugh to > describe the related results, is it make sense that we may remove > memberInfos in RemoveMembersFromConsumerGroupResult ? This KIP has no > dependency on this if we choose alternative 2) > > Could you advise? Thanks! > > Feyman > > > 送时间:2020年3月15日(星期

回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-18 Thread feyman2009
no dependency on this if we choose alternative 2) Could you advise? Thanks! Feyman 送时间:2020年3月15日(星期日) 10:11 收件人:dev 主 题:回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Hi, all Thanks a lot for your feedback! According to the discussion, it se

回复:回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-14 Thread feyman2009
Thanks! Feyman -- 发件人:Boyang Chen 发送时间:2020年3月14日(星期六) 00:39 收件人:dev 主 题:Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter Thanks Matthias and Guozhang for the feedback. I'm not worrying too much

Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-13 Thread Boyang Chen
Thanks Matthias and Guozhang for the feedback. I'm not worrying too much about the member.id exposure as we have done so in a couple of areas. As for the recommended admin client change, I think it makes sense in an encapsulation perspective. Maybe I'm still a bit hesitant as we are losing the flex

Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-12 Thread Guozhang Wang
Hi Matthias, About the AdminClient param API: that's a great point here. I think overall if users want to just "remove all members" they should not need to first get all the member.ids themselves, but instead internally the admin client can first issue a describe-group request to get all the membe

Re: 回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-12 Thread Matthias J. Sax
Feyman, some more comments/questions: The description of `LeaveGroupRequest` is clear but it's unclear how `MemberToRemove` should behave. Which parameter is required? Which is optional? What is the relationship between both. The `LeaveGroupRequest` description clearly states that specifying a `

回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-11 Thread feyman2009
Hi, Sophie For 1) Sorry, I found that my expression is kind of misleading, what I actually mean is: "if --force not specified, an exception saying there are still active members on broker side will be thrown and suggesting using StreamsResetter with --force", I just updated the KIP page.

回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-07 Thread feyman2009
Hi, Matthias Thanks, I updated the KIP to mention the deprecated and newly added methods. 1. What happens is `groupInstanceId` is used for a dynamic group? What happens if both parameters are specified? What happens if `memberId` is specified for a static group? => my understanding is that th

回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-03 Thread feyman2009
Hi, Guozhang Thanks a lot for the advice, that make sense! I have updated the KIP page with the operational steps of StreamsResetter. Thanks! Feyman -- 发件人:Guozhang Wang 发送时间:2020年3月3日(星期二) 14:22 收件人:dev ; feyman2009 主 题:R

回复:回复:回复:[Vote] KIP-571: Add option to force remove members in StreamsResetter

2020-03-02 Thread feyman2009
Hi, John Sorry, I have mistaken the KIP approval standard, anyway, I will start the PR soon and waiting for more binding approvals. Thanks! Feyman -- 发件人:John Roesler 发送时间:2020年3月2日(星期一) 22:00 收件人:dev 主 题:Re: 回复:回复:[Vote] KIP