Re: [kafka-clients] [VOTE] 2.4.0 RC0

2019-11-19 Thread Eric Lalonde
Hi all, Also seeing repeated failures of kafka.api.SaslPlainPlaintextConsumerTest > testCoordinatorFailover: kafka.api.SaslPlainPlaintextConsumerTest > testCoordinatorFailover FAILED java.lang.AssertionError: expected: but was: Given the nature of the error, it may be a timing issue in th

Re: [kafka-clients] [VOTE] 2.4.0 RC0

2019-11-18 Thread Matthias J. Sax
Fix via https://github.com/apache/kafka/pull/7707 Thanks for the quick fix Bruno! On 11/18/19 11:02 AM, Eric Lalonde wrote: > This test has been failing when executed from the command line. I have not > run this test in an IDE. > >> On Nov 18, 2019, at 6:16 AM, Bruno Cadonna wrote: >> >> Hi

Re: [kafka-clients] [VOTE] 2.4.0 RC0

2019-11-18 Thread Eric Lalonde
This test has been failing when executed from the command line. I have not run this test in an IDE. > On Nov 18, 2019, at 6:16 AM, Bruno Cadonna wrote: > > Hi, > > ClientMetricsTest.shouldAddCommitIdMetric should only fail if executed > from an IDE. The test fails because the test expects a f

Re: [kafka-clients] [VOTE] 2.4.0 RC0

2019-11-18 Thread Vahid Hashemian
Thanks Bruno, Just to clarify, I ran the tests from the command line: ./gradlew streams:test Regards, --Vahid On Mon, Nov 18, 2019 at 6:16 AM Bruno Cadonna wrote: > Hi, > > ClientMetricsTest.shouldAddCommitIdMetric should only fail if executed > from an IDE. The test fails because the test exp

Re: [kafka-clients] [VOTE] 2.4.0 RC0

2019-11-18 Thread Bruno Cadonna
Hi, ClientMetricsTest.shouldAddCommitIdMetric should only fail if executed from an IDE. The test fails because the test expects a file on the class path which is not there when the test is executed from the IDE, but is there when the test is executed from gradle. I will try to fix the test so that

Re: [kafka-clients] [VOTE] 2.4.0 RC0

2019-11-17 Thread Vahid Hashemian
Thanks Manikumar for managing this release. Looking forward to it. I built binary from the source and was able to successfully run the quickstarts. However, this streams unit test also fails for me constantly: ClientMetricsTest. shouldAddCommitIdMetric java.lang.AssertionError: Unexpected met