[
https://issues.apache.org/jira/browse/KAFKA-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665730#comment-13665730
]
Neha Narkhede commented on KAFKA-897:
-
+1. I think this looks good until we upgrade to
[
https://issues.apache.org/jira/browse/KAFKA-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652229#comment-13652229
]
Colin B. commented on KAFKA-897:
Looks like FilterOutputStream does not handle nulls.
java
[
https://issues.apache.org/jira/browse/KAFKA-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652152#comment-13652152
]
Colin B. commented on KAFKA-897:
I had been testing on 0.8 and did not notice KAFKA-739 (Ha
[
https://issues.apache.org/jira/browse/KAFKA-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652087#comment-13652087
]
Jun Rao commented on KAFKA-897:
---
Ok. So the confusing part is that the comment in the code is
[
https://issues.apache.org/jira/browse/KAFKA-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652041#comment-13652041
]
Jay Kreps commented on KAFKA-897:
-
Yup, I think we are confusing the protocol and the code.
[
https://issues.apache.org/jira/browse/KAFKA-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652035#comment-13652035
]
Jun Rao commented on KAFKA-897:
---
Thanks for the patch. Actually, I think the wiki is inaccura