[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-17 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556380#comment-13556380 ] Jun Rao commented on KAFKA-691: --- Actually, the current code works since partitionId is always

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-14 Thread Maxime Brugidou (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552759#comment-13552759 ] Maxime Brugidou commented on KAFKA-691: --- So I wait for your feedback first, but I gue

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552371#comment-13552371 ] Jun Rao commented on KAFKA-691: --- That's a good point. Increasing the timeout will work for mo

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-13 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552363#comment-13552363 ] Jay Kreps commented on KAFKA-691: - Does batching make sense versus just having people incre

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552336#comment-13552336 ] Jun Rao commented on KAFKA-691: --- It would be great if you can provide a patch. 1,2,3. Yes, w

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-12 Thread Maxime Brugidou (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551978#comment-13551978 ] Maxime Brugidou commented on KAFKA-691: --- Should i make another patch? I'll try on Mon

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551961#comment-13551961 ] Jun Rao commented on KAFKA-691: --- Another potential issue is that for producers that produce m

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550450#comment-13550450 ] Jun Rao commented on KAFKA-691: --- 3.1 It shouldn't. However, if you can reproduce this problem

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-10 Thread Maxime Brugidou (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550338#comment-13550338 ] Maxime Brugidou commented on KAFKA-691: --- Thanks for committing the patch. 3.1 Are yo

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549842#comment-13549842 ] Jun Rao commented on KAFKA-691: --- Thanks for the patch. Overall, the patch is pretty good and

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549373#comment-13549373 ] Jun Rao commented on KAFKA-691: --- DefaultEventHander.getPartitionListForTopic() returns Seq[Pa

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-09 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549276#comment-13549276 ] Jay Kreps commented on KAFKA-691: - That would be awesome. If you don't mind just give the p

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-09 Thread Maxime Brugidou (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549105#comment-13549105 ] Maxime Brugidou commented on KAFKA-691: --- I agree with Jun solution, this would solve

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548847#comment-13548847 ] Jun Rao commented on KAFKA-691: --- One thing we can do is to change the partitioner api so that

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-09 Thread Maxime Brugidou (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548667#comment-13548667 ] Maxime Brugidou commented on KAFKA-691: --- I think the work-around is not really accept