[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566599#comment-13566599 ] Jay Kreps commented on KAFKA-683: - The design was that the network layer is fully generic a

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566563#comment-13566563 ] Jun Rao commented on KAFKA-683: --- Yes, the main changes were made by me in kafka-203. If we wa

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566234#comment-13566234 ] Jay Kreps commented on KAFKA-683: - Yeah, I am on the fence about the metrics stuff, maybe i

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566205#comment-13566205 ] Neha Narkhede commented on KAFKA-683: - Understand and agree with you here. However, we

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551550#comment-13551550 ] Jun Rao commented on KAFKA-683: --- The changes in core/src/test/resources/log4j.properties are

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551340#comment-13551340 ] Jun Rao commented on KAFKA-683: --- Got the following compilation error on the latest rebase. [

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550879#comment-13550879 ] Jun Rao commented on KAFKA-683: --- For rebased v2 patch, the problem in #3 still exists. Also,

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550453#comment-13550453 ] Jun Rao commented on KAFKA-683: --- We can include in the request string sth like clientId:aaa,c

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549967#comment-13549967 ] Neha Narkhede commented on KAFKA-683: - That is a good suggestion. However, that still d

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549953#comment-13549953 ] Jun Rao commented on KAFKA-683: --- I agree that seeing the whole request is not useful, especia

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549792#comment-13549792 ] Jun Rao commented on KAFKA-683: --- Patch v2 doesn't seem to apply on 0.8. Could you rebase? Fo

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544506#comment-13544506 ] Jun Rao commented on KAFKA-683: --- Thanks for the patch. Some comments: 1. DefaultEventHandler