[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934469#comment-13934469
]
korebantic2 commented on KAFKA-657:
---
All,
I'm looking to update a client to support this
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544370#comment-13544370
]
Jay Kreps commented on KAFKA-657:
-
I updated the property name. Normally I am against comme
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544354#comment-13544354
]
David Arthur commented on KAFKA-657:
Jun,
80. Those commented out tests will be valid
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544322#comment-13544322
]
Jun Rao commented on KAFKA-657:
---
v8 looks good. Just some minor comments.
80. OffsetCommitTe
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544261#comment-13544261
]
Neha Narkhede commented on KAFKA-657:
-
+1 on v8
> Add an API to commit
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544054#comment-13544054
]
Jay Kreps commented on KAFKA-657:
-
This looks good to me. If no further objections I am tak
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543459#comment-13543459
]
Jay Kreps commented on KAFKA-657:
-
Works for me.
> Add an API to commit of
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543448#comment-13543448
]
David Arthur commented on KAFKA-657:
I have "offset.metadata.max.size" for the time bei
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543277#comment-13543277
]
Jay Kreps commented on KAFKA-657:
-
Yeah that is the right place for a new config. It is wor
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543227#comment-13543227
]
David Arthur commented on KAFKA-657:
We had talked about limiting the size of the metad
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542566#comment-13542566
]
Jay Kreps commented on KAFKA-657:
-
Looks good to me. A few things in addition to the other
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542540#comment-13542540
]
Jun Rao commented on KAFKA-657:
---
Thanks for patch v7. Some more comments:
70. OffsetFetchRes
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542390#comment-13542390
]
Joel Koshy commented on KAFKA-657:
--
Hey David, the patch (and the wiki) looks great.
- Fo
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542299#comment-13542299
]
David Arthur commented on KAFKA-657:
Post-holiday bump. Anyone had a chance to look at
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539141#comment-13539141
]
Neha Narkhede commented on KAFKA-657:
-
+1 on v5. Just a minor comment which I think Jun
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537390#comment-13537390
]
Jay Kreps commented on KAFKA-657:
-
Also I had one more generalization I would like to add--
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537368#comment-13537368
]
Jay Kreps commented on KAFKA-657:
-
It probably makes sense to do this in two phases. Let's
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537327#comment-13537327
]
Jun Rao commented on KAFKA-657:
---
Thanks for patch v4. Some comments:
40. Could you add the A
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537237#comment-13537237
]
Jun Rao commented on KAFKA-657:
---
I was trying to apply patch v3 in trunk (on a revision befor
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537062#comment-13537062
]
David Arthur commented on KAFKA-657:
Jay, the one thing I'm still unclear on are the va
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534233#comment-13534233
]
Jay Kreps commented on KAFKA-657:
-
Makes sense. The API is versioned so we can always add t
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534178#comment-13534178
]
David Arthur commented on KAFKA-657:
Yes, they are somewhat orthogonal. The only real u
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534162#comment-13534162
]
Jay Kreps commented on KAFKA-657:
-
I think that actually covers an orthogonal problem right
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534151#comment-13534151
]
David Arthur commented on KAFKA-657:
Re 3: Maybe this is a case for the check-and-set f
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534122#comment-13534122
]
Jay Kreps commented on KAFKA-657:
-
This looks great!
Three minor things:
1. Can you change
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530700#comment-13530700
]
Jay Kreps commented on KAFKA-657:
-
I wonder if you could take a look at the updated docs an
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530174#comment-13530174
]
David Arthur commented on KAFKA-657:
Thanks [~jkreps], that clears things up quite a bi
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529617#comment-13529617
]
Jay Kreps commented on KAFKA-657:
-
The existing API describes the offset ranges contained i
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529613#comment-13529613
]
David Arthur commented on KAFKA-657:
I'm fine working on the rest of 1. 1a is simple en
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529589#comment-13529589
]
Jay Kreps commented on KAFKA-657:
-
Oh yes, two other things:
1. We don't have a response in
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529583#comment-13529583
]
Jay Kreps commented on KAFKA-657:
-
This looks great. To confirm, the final format for the c
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526687#comment-13526687
]
David Arthur commented on KAFKA-657:
I have started a wiki page for this design discuss
32 matches
Mail list logo
