[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526125#comment-13526125 ] Jay Kreps commented on KAFKA-642: - It also baselines all versions, including the message ma

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511571#comment-13511571 ] Jay Kreps commented on KAFKA-642: - Ack, you're right. > Protocol tweaks fo

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511549#comment-13511549 ] Jun Rao commented on KAFKA-642: --- 60. What you said makes sense. But from IDE, that call maps

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511489#comment-13511489 ] Jay Kreps commented on KAFKA-642: - 60. This isn't an implict conversion. In java the method

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511152#comment-13511152 ] Jun Rao commented on KAFKA-642: --- Another thing. 62. FetchResponsePartitionData.initialOffset

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511139#comment-13511139 ] Jun Rao commented on KAFKA-642: --- Thanks for the patch. A couple of minor comments: 60. Topic

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511073#comment-13511073 ] Jay Kreps commented on KAFKA-642: - Neha: 12. No, that should be fine, right? The alternativ

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511022#comment-13511022 ] Joel Koshy commented on KAFKA-642: -- +1 BTW, is there a separate jira open on fetching met

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510878#comment-13510878 ] Neha Narkhede commented on KAFKA-642: - +1. Minor observations - 12. In OffsetRequest,

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508985#comment-13508985 ] Jay Kreps commented on KAFKA-642: - Updated patch addresses issues as per points above. Stil

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507846#comment-13507846 ] Neha Narkhede commented on KAFKA-642: - Thanks for the patch, reviewed the one that appl

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507807#comment-13507807 ] Neha Narkhede commented on KAFKA-642: - I guess we want to include this on the 0.8 branc

[jira] [Commented] (KAFKA-642) Protocol tweaks for 0.8

[ https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507773#comment-13507773 ] Jay Kreps commented on KAFKA-642: - Appears to pass basic system tests. > P