[
https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667548#comment-15667548
]
tony mancill commented on KAFKA-559:
Hi [~ewencp]. The attachment
[KAFKA-559.patch|ht
[
https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185380#comment-14185380
]
Ewen Cheslack-Postava commented on KAFKA-559:
-
This is an updated version of th
[
https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185377#comment-14185377
]
Ewen Cheslack-Postava commented on KAFKA-559:
-
Created reviewboard https://revi
[
https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703525#comment-13703525
]
Guozhang Wang commented on KAFKA-559:
-
One minor comment: add one debug() at the entry
[
https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703007#comment-13703007
]
Joel Koshy commented on KAFKA-559:
--
Thanks for the patch. Overall, looks good. Couple of
[
https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699819#comment-13699819
]
Swapnil Ghike commented on KAFKA-559:
-
Some feedback:
1. Passing a groupId for cleanup
[
https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698307#comment-13698307
]
Joel Koshy commented on KAFKA-559:
--
One additional recommendation: support a --dry-run opt
