[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-03-25 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379900#comment-14379900 ] Ashish K Singh commented on KAFKA-1856: --- Thanks for helping out [~charmalloc]! > Ad

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-03-24 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379331#comment-14379331 ] Joe Stein commented on KAFKA-1856: -- Testing file [KAFKA-1856_2015-02-04_15%3A44%3A47.pat

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334046#comment-14334046 ] Ashish Kumar Singh commented on KAFKA-1856: --- Sounds good [~charmalloc]! > Add P

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-23 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333560#comment-14333560 ] Joe Stein commented on KAFKA-1856: -- [~singhashish] I didn't want to make these changes wh

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-23 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333528#comment-14333528 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~charmalloc] were you able to get

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14332027#comment-14332027 ] Neha Narkhede commented on KAFKA-1856: -- This is cool. Thanks for working on this, [~s

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-09 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313546#comment-14313546 ] Ashish Kumar Singh commented on KAFKA-1856: --- Sounds good [~charmalloc]. Thanks!

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-09 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313509#comment-14313509 ] Joe Stein commented on KAFKA-1856: -- [~singhashish] I created a new jenkins build https:/

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-09 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312596#comment-14312596 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~gwenshap] and [~charmalloc] thank

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-07 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311140#comment-14311140 ] Gwen Shapira commented on KAFKA-1856: - Looks good! [~joestein] or [~nehanarkhede] - p

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-04 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306241#comment-14306241 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~gwenshap] added checkstyle checks

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-04 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306237#comment-14306237 ] Ashish Kumar Singh commented on KAFKA-1856: --- Updated reviewboard https://reviews

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-04 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306178#comment-14306178 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~gwenshap] so the issue was that y

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-04 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306164#comment-14306164 ] Ashish Kumar Singh commented on KAFKA-1856: --- Updated reviewboard https://reviews

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-04 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305833#comment-14305833 ] Gwen Shapira commented on KAFKA-1856: - Here's what I did and the result: {code} gshap

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-03 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304690#comment-14304690 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~gwenshap] I have tried the {{--ou

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-02-03 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303699#comment-14303699 ] Gwen Shapira commented on KAFKA-1856: - Once KAFKA-1915 is in, will be nice to include

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-20 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285105#comment-14285105 ] Gwen Shapira commented on KAFKA-1856: - Non-binding +1 from me :) Looks good and I'm ex

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282180#comment-14282180 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~gwenshap] I have tested both case

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282164#comment-14282164 ] Ashish Kumar Singh commented on KAFKA-1856: --- Updated reviewboard https://reviews

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282140#comment-14282140 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~gwenshap] in that case current lo

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282131#comment-14282131 ] Gwen Shapira commented on KAFKA-1856: - Patches where A.B.C branch exist, should be app

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-18 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282060#comment-14282060 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~joestein] thanks for the info her

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-17 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281546#comment-14281546 ] Joe Stein commented on KAFKA-1856: -- The way we have been developing since from incubation

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-17 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281523#comment-14281523 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~gwenshap] If jenkins job specifie

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-16 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281116#comment-14281116 ] Gwen Shapira commented on KAFKA-1856: - btw. can you test on a non-trunk version? like

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-16 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281102#comment-14281102 ] Gwen Shapira commented on KAFKA-1856: - It does! SQOOP's precommit hook contains a lin

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-16 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280991#comment-14280991 ] Ashish Kumar Singh commented on KAFKA-1856: --- So, I re-ran it on KAFKA-1664, htt

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-16 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280985#comment-14280985 ] Ashish Kumar Singh commented on KAFKA-1856: --- I can speak of Apache Hive. The con

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-16 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280959#comment-14280959 ] Gwen Shapira commented on KAFKA-1856: - Any idea what do other projects do about flaky

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-16 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280949#comment-14280949 ] Ashish Kumar Singh commented on KAFKA-1856: --- [~gwenshap] those errors are due to

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-16 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280890#comment-14280890 ] Gwen Shapira commented on KAFKA-1856: - [~singhashish], I see many errors in the tests

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-14 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277518#comment-14277518 ] Ashish Kumar Singh commented on KAFKA-1856: --- RB: https://reviews.apache.org/r/29

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-12 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273923#comment-14273923 ] Neha Narkhede commented on KAFKA-1856: -- Thanks for filing this [~singhashish]! Look f