[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-10-09 Thread Anton Karamanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165287#comment-14165287 ] Anton Karamanov commented on KAFKA-1644: That's great news, thanks. > Inherit Fet

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-10-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165278#comment-14165278 ] Jun Rao commented on KAFKA-1644: Ok, since this a small patch, I double committed to 0.8.2

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-10-08 Thread Anton Karamanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163449#comment-14163449 ] Anton Karamanov commented on KAFKA-1644: Thanks. Is there a chance it could be in

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-10-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161187#comment-14161187 ] Jun Rao commented on KAFKA-1644: Perhaps it's better to throw a UnsupportedOperationExcept

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-10-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159758#comment-14159758 ] Jun Rao commented on KAFKA-1644: Alexey, My only concern of the patch is that it gives pe

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-10-03 Thread Alexey Ozeritskiy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158114#comment-14158114 ] Alexey Ozeritskiy commented on KAFKA-1644: -- This patch simplifies writing clients

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-10-02 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156156#comment-14156156 ] Joe Stein commented on KAFKA-1644: -- Unless it is a bug or defect I don't see the point to

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-10-02 Thread Anton Karamanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156149#comment-14156149 ] Anton Karamanov commented on KAFKA-1644: Jun, no {{FetchResponseSend}} still uses

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-10-01 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155903#comment-14155903 ] Jun Rao commented on KAFKA-1644: Anton, By letting FetchResponseSend to call FetchRespons

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-10-01 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155678#comment-14155678 ] Guozhang Wang commented on KAFKA-1644: -- Anton, I think Jun's not saying that there is

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-09-28 Thread Anton Karamanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151423#comment-14151423 ] Anton Karamanov commented on KAFKA-1644: Does this prevent it from being inherited

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-09-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151136#comment-14151136 ] Jun Rao commented on KAFKA-1644: The reason that FetchResponse is special is that it uses

[jira] [Commented] (KAFKA-1644) Inherit FetchResponse from RequestOrResponse

2014-09-22 Thread Anton Karamanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143112#comment-14143112 ] Anton Karamanov commented on KAFKA-1644: Here's a [patch|^0001-KAFKA-1644-Inherit