[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188577#comment-14188577 ] Joel Koshy commented on KAFKA-1583: --- Ok cool - I will re-review the latest patch and sho

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187960#comment-14187960 ] Jun Rao commented on KAFKA-1583: [~jjkoshy], you can commit the patch once you are done wi

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187571#comment-14187571 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-28 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187118#comment-14187118 ] Joel Koshy commented on KAFKA-1583: --- Thanks for the updated patch. I will do this today.

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-22 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180899#comment-14180899 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-22 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180037#comment-14180037 ] Guozhang Wang commented on KAFKA-1583: -- Yes, the system tests without the offset mana

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179460#comment-14179460 ] Joel Koshy commented on KAFKA-1583: --- I posted review comments, mostly minor. Did you ge

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175763#comment-14175763 ] Joel Koshy commented on KAFKA-1583: --- Reviewing is taking a bit longer than expected - I'

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-17 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175239#comment-14175239 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-16 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174709#comment-14174709 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-15 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173215#comment-14173215 ] Joel Koshy commented on KAFKA-1583: --- Yes please. I will be able to do this on Friday. >

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173210#comment-14173210 ] Jun Rao commented on KAFKA-1583: Just reviewed it. Joel, Do you want to take another loo

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171998#comment-14171998 ] Guozhang Wang commented on KAFKA-1583: -- Bump, [~junrao] could you take a look now? >

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170405#comment-14170405 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167187#comment-14167187 ] Guozhang Wang commented on KAFKA-1583: -- Sure, will do that asap. > Kafka API Refacto

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167184#comment-14167184 ] Jun Rao commented on KAFKA-1583: Guozhang, Now that the 0.8.2 branch is cut, do you want

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-09-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141318#comment-14141318 ] Joel Koshy commented on KAFKA-1583: --- Yes I intend to review this within the next couple

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-09-19 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141316#comment-14141316 ] Guozhang Wang commented on KAFKA-1583: -- That is fine. I will wait then. > Kafka API

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-09-19 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141310#comment-14141310 ] Jun Rao commented on KAFKA-1583: Hi, Guozhang, Yes, since this is a relatively large patc

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-09-19 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141242#comment-14141242 ] Guozhang Wang commented on KAFKA-1583: -- [~junrao] [~jjkoshy] Could you give this a lo

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-09-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123664#comment-14123664 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-09-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123581#comment-14123581 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-09-02 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118696#comment-14118696 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-09-01 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117812#comment-14117812 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-08-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112421#comment-14112421 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-08-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105739#comment-14105739 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-08-20 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104560#comment-14104560 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-08-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096287#comment-14096287 ] Guozhang Wang commented on KAFKA-1583: -- Created reviewboard https://reviews.apache.or