[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076660#comment-14076660
]
ASF GitHub Bot commented on KAFKA-1414:
---
Github user ataraxer closed the pull reques
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075671#comment-14075671
]
Jun Rao commented on KAFKA-1414:
50. Got it. I was thinking that if for some reason, one o
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074699#comment-14074699
]
Anton Karamanov commented on KAFKA-1414:
50. in this case `for` used for safe and
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074625#comment-14074625
]
Jun Rao commented on KAFKA-1414:
Thanks for patch v4. Looks good. Some minor comments belo
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074119#comment-14074119
]
Dmitry Bugaychenko commented on KAFKA-1414:
---
I'm not a scala expert, but the thr
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073649#comment-14073649
]
Anton Karamanov commented on KAFKA-1414:
So what about the last version of a patch
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071573#comment-14071573
]
Anton Karamanov commented on KAFKA-1414:
[~junrao], yes, caches were dropped befor
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070945#comment-14070945
]
Jun Rao commented on KAFKA-1414:
Anton,
Just curious in your experiment, is the data comp
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070642#comment-14070642
]
Dmitry Bugaychenko commented on KAFKA-1414:
---
"data dir" and "log dir" seems more
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070634#comment-14070634
]
Anton Karamanov commented on KAFKA-1414:
Second approach seems fine to me as well.
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070555#comment-14070555
]
Dmitry Bugaychenko commented on KAFKA-1414:
---
We would prefer the second approach
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070542#comment-14070542
]
Jay Kreps commented on KAFKA-1414:
--
Cool, that is a great speed-up either way.
I'm fine
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070489#comment-14070489
]
Anton Karamanov commented on KAFKA-1414:
Here are some measurements for 4 disks, e
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068566#comment-14068566
]
Anton Karamanov commented on KAFKA-1414:
[~jkreps], we are testing different combi
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068561#comment-14068561
]
Jay Kreps commented on KAFKA-1414:
--
[~arhagnel] I share your concern. I just want to make
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068336#comment-14068336
]
Anton Karamanov commented on KAFKA-1414:
Dir-level parallelization will prevent mu
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068333#comment-14068333
]
Dmitry Bugaychenko commented on KAFKA-1414:
---
According our experience in operati
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068177#comment-14068177
]
Jay Kreps commented on KAFKA-1414:
--
[~ataraxer] I agree that just throwing all the logs a
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068173#comment-14068173
]
Jay Kreps commented on KAFKA-1414:
--
I did a test of single-threaded recovery on my laptop
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068021#comment-14068021
]
Jay Kreps commented on KAFKA-1414:
--
We should check that having multiple threads accessin
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068020#comment-14068020
]
Dmitry Bugaychenko commented on KAFKA-1414:
---
Separate thread pool per each dir w
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068018#comment-14068018
]
Oleg Golovin commented on KAFKA-1414:
-
[~junrao] wrote about parallelization over dire
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068015#comment-14068015
]
Dmitry Bugaychenko commented on KAFKA-1414:
---
That is why in my initial proposal
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068014#comment-14068014
]
Oleg Golovin commented on KAFKA-1414:
-
I see only one problem here. If we disperse thr
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068013#comment-14068013
]
Dmitry Bugaychenko commented on KAFKA-1414:
---
In our use case inter-directory par
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068007#comment-14068007
]
Anton Karamanov commented on KAFKA-1414:
I see the problem now. I still think that
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067986#comment-14067986
]
Oleg Golovin commented on KAFKA-1414:
-
[~ataraxer], you seem to run all the threadpool
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067917#comment-14067917
]
Alexey Ozeritskiy commented on KAFKA-1414:
--
You must create an instance of Runnab
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067884#comment-14067884
]
Anton Karamanov commented on KAFKA-1414:
[~aozeritsky] are you testing shutdown or
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067872#comment-14067872
]
Alexey Ozeritskiy commented on KAFKA-1414:
--
Anton, your patch is not working for
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067380#comment-14067380
]
Jun Rao commented on KAFKA-1414:
Oh, I was thinking about the local var referenced in load
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067065#comment-14067065
]
Anton Karamanov commented on KAFKA-1414:
But that would actually require changing
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067014#comment-14067014
]
Jun Rao commented on KAFKA-1414:
I can't think of better names. So that sounds good.
> Sp
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066847#comment-14066847
]
Anton Karamanov commented on KAFKA-1414:
Thanks for the review.
40.1. Maybe it wo
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066477#comment-14066477
]
Jun Rao commented on KAFKA-1414:
Thanks for patch v4. Some more comments.
40. LogManager:
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066031#comment-14066031
]
Anton Karamanov commented on KAFKA-1414:
[~jkreps], I've never actually encountere
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065721#comment-14065721
]
Jay Kreps commented on KAFKA-1414:
--
Hey [~aozeritsky], any before/after perf numbers for
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065034#comment-14065034
]
Jun Rao commented on KAFKA-1414:
Thanks for patch v3. A few more comments.
30. No need to
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063886#comment-14063886
]
Anton Karamanov commented on KAFKA-1414:
I like the idea of using more informative
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063742#comment-14063742
]
Jay Kreps commented on KAFKA-1414:
--
Great patch!
I second Jun's comments.
Is there a wa
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063733#comment-14063733
]
Anton Karamanov commented on KAFKA-1414:
21.3 There were similar logging at {{load
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063708#comment-14063708
]
Jun Rao commented on KAFKA-1414:
Thanks for the patch. A few comments.
20. KafkaServer an
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062695#comment-14062695
]
Jun Rao commented on KAFKA-1414:
Anton,
Thanks for the patch. Could you add the patch as
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062686#comment-14062686
]
Anton Karamanov commented on KAFKA-1414:
Indeed, patch was malformed.
I've fixed
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062680#comment-14062680
]
ASF GitHub Bot commented on KAFKA-1414:
---
GitHub user ataraxer opened a pull request:
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061957#comment-14061957
]
Alexey Ozeritskiy commented on KAFKA-1414:
--
Anton, you forget to use new config o
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061731#comment-14061731
]
Dmitry Bugaychenko commented on KAFKA-1414:
---
Any plans regarding parallel shutdo
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056417#comment-14056417
]
Jun Rao commented on KAFKA-1414:
2. Yes, that probably right. Could you verify that the or
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056358#comment-14056358
]
Alexey Ozeritskiy commented on KAFKA-1414:
--
1. Ok
2. If any thread fails we get E
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056338#comment-14056338
]
Jun Rao commented on KAFKA-1414:
Thanks for the patch. A few comments.
1. If there are lo
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056065#comment-14056065
]
Alexey Ozeritskiy commented on KAFKA-1414:
--
You are right. I have made new versio
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053207#comment-14053207
]
Jun Rao commented on KAFKA-1414:
Hmm, I am not sure if you should drop the support of scal
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053203#comment-14053203
]
Evgeny Vereshchagin commented on KAFKA-1414:
{quote}
scala 2.8 is really old a
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053171#comment-14053171
]
Jun Rao commented on KAFKA-1414:
scala 2.8 is really old and we could drop the 2.8 support
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053167#comment-14053167
]
Evgeny Vereshchagin commented on KAFKA-1414:
Changelog: [2.9.0|http://www.scal
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053151#comment-14053151
]
Jun Rao commented on KAFKA-1414:
Thanks for the patch. The compilation fails though since
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981025#comment-13981025
]
Dmitry Bugaychenko commented on KAFKA-1414:
---
Actually similar improvement is nee
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980971#comment-13980971
]
Alexey Ozeritskiy commented on KAFKA-1414:
--
What to do with exceptions? Maybe we
58 matches
Mail list logo
