[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921560#comment-13921560
]
Neha Narkhede commented on KAFKA-1286:
--
[~jkreps] Ya, you're right. I was reading it
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921546#comment-13921546
]
Jay Kreps commented on KAFKA-1286:
--
Jun, cool changed it to always use the double operato
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921519#comment-13921519
]
Jun Rao commented on KAFKA-1286:
For 1, yes, they are equivalent. My concern is that the u
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921443#comment-13921443
]
Jay Kreps commented on KAFKA-1286:
--
Jun:
1. They are equivalent for booleans but I wouldn
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921175#comment-13921175
]
Neha Narkhede commented on KAFKA-1286:
--
Shouldn't backingOff be (batch.attempts > 0 &
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921164#comment-13921164
]
Jun Rao commented on KAFKA-1286:
A couple of minor comments:
1. In RecordAccumulator, sho
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920465#comment-13920465
]
Jay Kreps commented on KAFKA-1286:
--
This looks good to me. I got one compilation error du
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920390#comment-13920390
]
Guozhang Wang commented on KAFKA-1286:
--
Updated reviewboard https://reviews.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920186#comment-13920186
]
Guozhang Wang commented on KAFKA-1286:
--
Updated reviewboard https://reviews.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919775#comment-13919775
]
Guozhang Wang commented on KAFKA-1286:
--
Updated reviewboard https://reviews.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919756#comment-13919756
]
Guozhang Wang commented on KAFKA-1286:
--
Created reviewboard https://reviews.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918457#comment-13918457
]
Guozhang Wang commented on KAFKA-1286:
--
Thanks for the guidance Jay, I can take this
[
https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918451#comment-13918451
]
Jay Kreps commented on KAFKA-1286:
--
If you are saying that we repeat the metadata request
13 matches
Mail list logo
