Re: [VOTE] KIP 771: KRaft brokers should not expose controller metrics

Hello all, Thank you all for the votes! With 3 binding and 1 non-binding vote this KIP will be accepted. Regards, Ryan Dielhenn On Tue, Sep 21, 2021 at 11:44 AM Ismael Juma wrote: > Thanks for the KIP, +1 (binding). > > Ismael > > On Thu, Sep 2, 2021 at 1:20 PM Ryan Dielhenn .invalid> > wrote

Re: [VOTE] KIP 771: KRaft brokers should not expose controller metrics

Thanks for the KIP, +1 (binding). Ismael On Thu, Sep 2, 2021 at 1:20 PM Ryan Dielhenn wrote: > Hello kafka devs, > > I would like to start a vote on KIP-771. This KIP proposes to not expose > controller metrics on KRaft brokers since KRaft brokers are not controller > eligible and will never ha

Re: [VOTE] KIP 771: KRaft brokers should not expose controller metrics

+1, non-binding from me. Thanks, Ryan. Ron > On Sep 7, 2021, at 5:54 PM, Guozhang Wang wrote: > > Thanks Ryan, > > Read the KIP and it makes sense. +1 as well. > >> On Tue, Sep 7, 2021 at 1:42 PM Colin McCabe wrote: >> >> +1 (binding) >> >> thanks, Ryan >> >> best, >> Colin >> >>> On T

Re: [VOTE] KIP 771: KRaft brokers should not expose controller metrics

Thanks Ryan, Read the KIP and it makes sense. +1 as well. On Tue, Sep 7, 2021 at 1:42 PM Colin McCabe wrote: > +1 (binding) > > thanks, Ryan > > best, > Colin > > On Tue, Sep 7, 2021, at 09:47, Colin McCabe wrote: > > Hi Ryan, > > > > Thanks for working on this. I think it is almost ready to go

Re: [VOTE] KIP 771: KRaft brokers should not expose controller metrics

+1 (binding) thanks, Ryan best, Colin On Tue, Sep 7, 2021, at 09:47, Colin McCabe wrote: > Hi Ryan, > > Thanks for working on this. I think it is almost ready to go. However, > I left a comment about the wording of the KIP in the DISCUSS thread. > > best, > Colin > > > On Thu, Sep 2, 2021,

Re: [VOTE] KIP 771: KRaft brokers should not expose controller metrics

Hi Ryan, Thanks for working on this. I think it is almost ready to go. However, I left a comment about the wording of the KIP in the DISCUSS thread. best, Colin On Thu, Sep 2, 2021, at 13:20, Ryan Dielhenn wrote: > Hello kafka devs, > > I would like to start a vote on KIP-771. This KIP propos

[VOTE] KIP 771: KRaft brokers should not expose controller metrics

Hello kafka devs, I would like to start a vote on KIP-771. This KIP proposes to not expose controller metrics on KRaft brokers since KRaft brokers are not controller eligible and will never have a non-zero value for the metric. Since exposing metrics that will always be zero is both unneeded and c