Re: [VOTE] KIP-932: Queues for Kafka

2024-08-15 Thread Jun Rao
Hi, Andrew, Thanks for the clarification. Sounds good. Jun On Thu, Aug 15, 2024 at 2:53 AM Andrew Schofield wrote: > Hi Jun, > Thanks for the questions. > > 1. The PartitionMetadata is only stored if there is rack ID information. > So, there are situations in which it’s redundant, but almost a

Re: [VOTE] KIP-932: Queues for Kafka

2024-08-15 Thread Andrew Schofield
Hi Jun, Thanks for the questions. 1. The PartitionMetadata is only stored if there is rack ID information. So, there are situations in which it’s redundant, but almost always the PartitionMetadata will be empty. 2. They are for subtly different purposes. ShareGroupPartitionMetadata is essentially

Re: [VOTE] KIP-932: Queues for Kafka

2024-08-13 Thread Jun Rao
Hi, Andrew, Thanks for the update. A couple of followup questions. 1. ShareGroupPartitionMetadataValue: Is NumPartitions redundant given PartitionMetadata? 2. I assume that ShareGroupPartitionMetadataValue contains initialized partitions. Does that make ShareGroupStatePartitionMetadataValue.Init

Re: [VOTE] KIP-932: Queues for Kafka

2024-08-13 Thread Andrew Schofield
Hi, During the implementation of the group management code for KIP-932, we learnt that the decision not to persist assignments for share groups was making it difficult to fit with the coordinator framework, in particular the use of timeline structures. As a result, I decided to change the KIP to fo

Re: [VOTE] KIP-932: Queues for Kafka

2024-05-21 Thread Andrew Schofield
Hi Jun, All the client metrics are standard. None are required. I’ve updated the KIP accordingly. Thanks, Andrew > On 15 May 2024, at 21:36, Jun Rao wrote: > > Hi, Andrew, > > Thanks for the update. Should we mark whether those metrics are > standard/required for KIP-714? > > Jun > > On Tue

Re: [VOTE] KIP-932: Queues for Kafka

2024-05-19 Thread Andrew Schofield
Hi, KIP-932 has been approved. +5 (binding) - Edoardo Comar, Jun Rao, Satish Duggana, Manikumar Reddy, David Jacot +4 (non-binding) - Lianet Magrans, Apoorv Mittal, Kenneth Eversole, Omnia Ibrahim Thanks very much to everyone who put so much effort into reviewing this complicated KIP. The a

Re: [VOTE] KIP-932: Queues for Kafka

2024-05-16 Thread Omnia Ibrahim
Thanks for the KIP Andrew +1 none binding from me > On 16 May 2024, at 14:23, David Jacot wrote: > > Hi Andrew, > > Thanks for the KIP! This is really exciting! +1 (binding) from me. > > One note regarding the partition assignor interface changes that you > proposed, it would be great to get t

Re: [VOTE] KIP-932: Queues for Kafka

2024-05-16 Thread David Jacot
Hi Andrew, Thanks for the KIP! This is really exciting! +1 (binding) from me. One note regarding the partition assignor interface changes that you proposed, it would be great to get the changes in 3.8 in order to not break the API of KIP-848 after the preview. Best, David On Wed, May 15, 2024 a

Re: [VOTE] KIP-932: Queues for Kafka

2024-05-15 Thread Jun Rao
Hi, Andrew, Thanks for the update. Should we mark whether those metrics are standard/required for KIP-714? Jun On Tue, May 14, 2024 at 7:31 AM Andrew Schofield wrote: > Hi, > I have made a small update to the KIP as a result of testing the new > share consumer with client telemetry (KIP-714).

Re: [VOTE] KIP-932: Queues for Kafka

2024-05-14 Thread Andrew Schofield
Hi, I have made a small update to the KIP as a result of testing the new share consumer with client telemetry (KIP-714). I’ve added telemetry metric names to the table of client metrics and also updated the metric group names so that the resulting client metrics sent to the broker have consistent

Re: [VOTE] KIP-932: Queues for Kafka

2024-05-08 Thread Manikumar
Hi Andrew, Thanks for the KIP. Great write-up! +1 (binding) Thanks, On Wed, May 8, 2024 at 12:17 PM Satish Duggana wrote: > > Hi Andrew, > Thanks for the nice KIP, it will allow other messaging use cases to be > onboarded to Kafka. > > +1 from me. > > Satish. > > On Tue, 7 May 2024 at 03:41,

Re: [VOTE] KIP-932: Queues for Kafka

2024-05-07 Thread Satish Duggana
Hi Andrew, Thanks for the nice KIP, it will allow other messaging use cases to be onboarded to Kafka. +1 from me. Satish. On Tue, 7 May 2024 at 03:41, Jun Rao wrote: > > Hi, Andrew, > > Thanks for the KIP. +1 > > Jun > > On Mon, Mar 18, 2024 at 11:00 AM Edoardo Comar > wrote: > > > Thanks Andr

Re: [VOTE] KIP-932: Queues for Kafka

2024-05-06 Thread Jun Rao
Hi, Andrew, Thanks for the KIP. +1 Jun On Mon, Mar 18, 2024 at 11:00 AM Edoardo Comar wrote: > Thanks Andrew, > > +1 (binding) > > Edo > > On Mon, 18 Mar 2024 at 16:32, Kenneth Eversole > wrote: > > > > Hi Andrew > > > > + 1 (Non-Binding) > > > > This will be great addition to Kafka > > > > O

Re: [VOTE] KIP-932: Queues for Kafka

2024-03-18 Thread Edoardo Comar
Thanks Andrew, +1 (binding) Edo On Mon, 18 Mar 2024 at 16:32, Kenneth Eversole wrote: > > Hi Andrew > > + 1 (Non-Binding) > > This will be great addition to Kafka > > On Mon, Mar 18, 2024 at 8:27 AM Apoorv Mittal > wrote: > > > Hi Andrew, > > Thanks for writing the KIP. This is indeed going to

Re: [VOTE] KIP-932: Queues for Kafka

2024-03-18 Thread Kenneth Eversole
Hi Andrew + 1 (Non-Binding) This will be great addition to Kafka On Mon, Mar 18, 2024 at 8:27 AM Apoorv Mittal wrote: > Hi Andrew, > Thanks for writing the KIP. This is indeed going to be a valuable addition > to the Kafka, excited to see the KIP. > > + 1 (Non-Binding) > > Regards, > Apoorv Mi

Re: [VOTE] KIP-932: Queues for Kafka

2024-03-18 Thread Apoorv Mittal
Hi Andrew, Thanks for writing the KIP. This is indeed going to be a valuable addition to the Kafka, excited to see the KIP. + 1 (Non-Binding) Regards, Apoorv Mittal +44 7721681581 On Sun, Mar 17, 2024 at 11:16 PM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi, > I’ve been wo

Re: [VOTE] KIP-932: Queues for Kafka

2024-03-18 Thread Lianet M.
Hi Andrew, Happy to see this KIP unleashing the capabilities of Kafka, from the core up, to elegantly bring in a new, long wanted consumption pattern. +1 (non-binding) Lianet On Sun, Mar 17, 2024, 7:06 p.m. Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi, > I’ve been working

[VOTE] KIP-932: Queues for Kafka

2024-03-17 Thread Andrew Schofield
Hi, I’ve been working to complete KIP-932 over the past few months and discussions have quietened down. I’d like to open the voting for KIP-932: https://cwiki.apache.org/confluence/display/KAFKA/KIP-932%3A+Queues+for+Kafka Thanks, Andrew