Re: [VOTE] KIP-884: Add config to configure KafkaClientSupplier in Kafka Streams

Thanks Hao. I think it makes sense to extend `StreamsConfig` as proposed. -Matthias On 12/7/22 10:26 AM, Hao Li wrote: Hi all, I updated the KIP to add a `getKafkaClientSupplier` method in `StreamsConfig`. Let me know if you have any concerns. Thanks, Hao On Wed, Nov 30, 2022 at 10:26 AM Hao

Re: [VOTE] KIP-884: Add config to configure KafkaClientSupplier in Kafka Streams

Hi all, I updated the KIP to add a `getKafkaClientSupplier` method in `StreamsConfig`. Let me know if you have any concerns. Thanks, Hao On Wed, Nov 30, 2022 at 10:26 AM Hao Li wrote: > Hi all, > > Thanks for the vote. The vote passed with 4 binding votes (John, Matthias, > Sophie and Bruno).

Re: [VOTE] KIP-884: Add config to configure KafkaClientSupplier in Kafka Streams

Hi all, Thanks for the vote. The vote passed with 4 binding votes (John, Matthias, Sophie and Bruno). I'll update KIP and submit a PR for this. Thanks, Hao On Tue, Nov 22, 2022 at 11:08 PM Bruno Cadonna wrote: > Hi Hao, > > Thanks for the KIP! > > +1 (binding) > > Best, > Bruno > > On 22.11.2

Re: [VOTE] KIP-884: Add config to configure KafkaClientSupplier in Kafka Streams

Hi Hao, Thanks for the KIP! +1 (binding) Best, Bruno On 22.11.22 10:08, Sophie Blee-Goldman wrote: Hey Hao, thanks for the KIP -- I'm +1 (binding) On Mon, Nov 21, 2022 at 12:57 PM Matthias J. Sax wrote: +1 (binding) On 11/21/22 7:39 AM, John Roesler wrote: I'm +1 (binding) Thanks for t

Re: [VOTE] KIP-884: Add config to configure KafkaClientSupplier in Kafka Streams

Hey Hao, thanks for the KIP -- I'm +1 (binding) On Mon, Nov 21, 2022 at 12:57 PM Matthias J. Sax wrote: > +1 (binding) > > On 11/21/22 7:39 AM, John Roesler wrote: > > I'm +1 (binding) > > > > Thanks for the KIP! > > -John > > > > On 2022/11/17 21:06:29 Hao Li wrote: > >> Hi all, > >> > >> I wou

Re: [VOTE] KIP-884: Add config to configure KafkaClientSupplier in Kafka Streams

+1 (binding) On 11/21/22 7:39 AM, John Roesler wrote: I'm +1 (binding) Thanks for the KIP! -John On 2022/11/17 21:06:29 Hao Li wrote: Hi all, I would like start a vote on KIP-884: https://cwiki.apache.org/confluence/display/KAFKA/KIP-884%3A+Add+config+to+configure+KafkaClientSupplier+in+Kaf

Re: [VOTE] KIP-884: Add config to configure KafkaClientSupplier in Kafka Streams

I'm +1 (binding) Thanks for the KIP! -John On 2022/11/17 21:06:29 Hao Li wrote: > Hi all, > > I would like start a vote on KIP-884: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-884%3A+Add+config+to+configure+KafkaClientSupplier+in+Kafka+Streams > > > Thanks, > Hao >

[VOTE] KIP-884: Add config to configure KafkaClientSupplier in Kafka Streams

Hi all, I would like start a vote on KIP-884: https://cwiki.apache.org/confluence/display/KAFKA/KIP-884%3A+Add+config+to+configure+KafkaClientSupplier+in+Kafka+Streams Thanks, Hao