Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-12 Thread Yash Mayya
Hi Chris, Thanks, that makes sense - I hadn't considered the case where the worker itself becomes a zombie. Thanks, Yash On Wed, Apr 12, 2023 at 10:40 PM Chris Egerton wrote: > Hi Yash, > > Great, we can use the transactional ID for task zero for now 👍 > > As far as why: we'd need to fence out

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-12 Thread Chris Egerton
Hi Yash, Great, we can use the transactional ID for task zero for now 👍 As far as why: we'd need to fence out that producer in the event that tasks for the connector are brought up while the alter offsets request is still taking place, since we'd want to make sure that the offsets aren't altered

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-12 Thread Yash Mayya
Hi Chris and Greg, The current implementation does already use the transactional ID for task 0 so no complaints from me. Although I'm not sure I follow the concerns w.r.t zombie fencing? In which cases would we need to fence out the transactional producer instantiated for altering offsets? Thanks

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-12 Thread Chris Egerton
Hi Greg, I hadn't considered the implications W/R/T zombie fencing. I agree that using the transactional ID for task 0 is better in that case. Yash (who is implementing this part, cc'd), does this seem reasonable to you? Cheers, Chris On Tue, Apr 11, 2023 at 3:23 PM Greg Harris wrote: > Chri

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-11 Thread Greg Harris
Chris & Yash, 1. Since the global offsets topic does not have transactions on it already, I don't think adding transactions just for these reset operations would be an improvement. The transactional produce would not exclude other non-transactional producers, but hanging transactions on the global

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-11 Thread Chris Egerton
Hi all, A couple slight tweaks to the design have been proposed during implementation and I'd like to report them here to make sure that they're acceptable to all who previously voted for this KIP. I've updated the KIP to include these changes but will be happy to revert and/or amend if there are

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-03-03 Thread Chris Egerton
Hi all, Thanks for the votes! I'll cast a final +1 myself and close the vote out. This KIP passes with the following +1 votes (and no +0 or -1 votes): • Greg Harris • Yash Mayya • Knowles Atchison Jr • Mickael Maison (binding) • Tom Bentley (binding) • Josep Prat (binding) • Chris Egerton (bindi

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-03-03 Thread Josep Prat
Hi Chris, Thanks for the KIP. I have a non-blocking comment on the DISCUSS thread. +1 (binding). Best, On Wed, Mar 1, 2023 at 12:16 PM Tom Bentley wrote: > Hi Chris, > > Thanks for the KIP. > > +1 (binding). > > Cheers, > > Tom > > On Wed, 15 Feb 2023 at 16:11, Chris Egerton > wrote: > > > H

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-03-01 Thread Tom Bentley
Hi Chris, Thanks for the KIP. +1 (binding). Cheers, Tom On Wed, 15 Feb 2023 at 16:11, Chris Egerton wrote: > Hi all, > > Thanks to everyone who's voted so far! Just wanted to bump this thread and > see if we could get a few more votes; currently we're at +3 non-binding > and +1 binding. Hopi

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-02-15 Thread Chris Egerton
Hi all, Thanks to everyone who's voted so far! Just wanted to bump this thread and see if we could get a few more votes; currently we're at +3 non-binding and +1 binding. Hoping we can get this approved, reviewed, and merged in time for 3.5.0. Cheers, Chris On Tue, Jan 31, 2023 at 2:52 AM Micka

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-01-30 Thread Mickael Maison
Thanks Chris for the KIP, this is a much needed feature! +1 (binding) On Tue, Jan 24, 2023 at 3:45 PM Knowles Atchison Jr wrote: > > +1 (non binding) > > On Tue, Jan 24, 2023 at 5:24 AM Yash Mayya wrote: > > > Hi Chris, > > > > I'm +1 (non-binding). Thanks again for proposing this extremely >

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-01-24 Thread Knowles Atchison Jr
+1 (non binding) On Tue, Jan 24, 2023 at 5:24 AM Yash Mayya wrote: > Hi Chris, > > I'm +1 (non-binding). Thanks again for proposing this extremely > valuable addition to Kafka Connect! > > Thanks, > Yash > > On Thu, Jan 19, 2023 at 12:11 AM Chris Egerton > wrote: > > > Hi all, > > > > I'd like

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-01-24 Thread Yash Mayya
Hi Chris, I'm +1 (non-binding). Thanks again for proposing this extremely valuable addition to Kafka Connect! Thanks, Yash On Thu, Jan 19, 2023 at 12:11 AM Chris Egerton wrote: > Hi all, > > I'd like to call for a vote on KIP-875, which adds support for viewing and > manipulating the offsets o

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-01-23 Thread Greg Harris
Hi Chris, I'm +1 (non-binding) for KIP-875. Thanks for proposing this change! Greg Harris On Wed, Jan 18, 2023 at 10:41 AM Chris Egerton wrote: > Hi all, > > I'd like to call for a vote on KIP-875, which adds support for viewing and > manipulating the offsets of connectors to the Kafka Connect

[VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-01-18 Thread Chris Egerton
Hi all, I'd like to call for a vote on KIP-875, which adds support for viewing and manipulating the offsets of connectors to the Kafka Connect REST API. The KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-875%3A+First-class+offsets+support+in+Kafka+Connect The discussion thread: https