Re: [VOTE] KIP-866 ZooKeeper to KRaft Migration

2024-11-11 Thread Colin McCabe
Hi all, I was doing some JIRA cleanup and noticed someone commenting about the language in KIP-866 referencing an offline KRaft -> ZK conversion tool. Since we never ended up implementing this, I have removed it from the KIP. best, Colin On Wed, Nov 30, 2022, at 12:27, David Arthur wrote: > H

Re: [VOTE] KIP-866 ZooKeeper to KRaft Migration

2022-11-30 Thread David Arthur
Hey everyone, I'm going to close out the vote. There were three +1 votes from PMC members and no committer or community votes. +1 PMC votes: * Colin McCabe * Jason Gustafson * Jun Rao With that, the vote passes. Thanks to everyone who reviewed this KIP! Cheers, David On Tue, Nov 29, 2022 at 7:4

Re: [VOTE] KIP-866 ZooKeeper to KRaft Migration

2022-11-29 Thread Jun Rao
Hi, David, Thanks for the KIP. +1 Jun On Tue, Nov 22, 2022 at 3:43 PM Jason Gustafson wrote: > Thanks, +1 from me. I suspect we might be in for at least one surprise with > the re-implemented controller RPCs, but I agree the alternative has risks > as well. > > Best, > Jason > > On Mon, Nov 14

Re: [VOTE] KIP-866 ZooKeeper to KRaft Migration

2022-11-22 Thread Jason Gustafson
Thanks, +1 from me. I suspect we might be in for at least one surprise with the re-implemented controller RPCs, but I agree the alternative has risks as well. Best, Jason On Mon, Nov 14, 2022 at 12:00 PM Colin McCabe wrote: > On Fri, Nov 11, 2022, at 08:59, David Arthur wrote: > > Thanks, Colin

Re: [VOTE] KIP-866 ZooKeeper to KRaft Migration

2022-11-14 Thread Colin McCabe
On Fri, Nov 11, 2022, at 08:59, David Arthur wrote: > Thanks, Colin. > >> never start an upgrade without first verifying the quorum configuration on >> the ZK-based brokers > > I agree that this is a pretty big benefit. I could imagine debugging > and fixing connection problems mid-migration would

Re: [VOTE] KIP-866 ZooKeeper to KRaft Migration

2022-11-11 Thread David Arthur
Thanks, Colin. > never start an upgrade without first verifying the quorum configuration on > the ZK-based brokers I agree that this is a pretty big benefit. I could imagine debugging and fixing connection problems mid-migration would be a big pain. Especially if you had some brokers correctly c

Re: [VOTE] KIP-866 ZooKeeper to KRaft Migration

2022-11-09 Thread Colin McCabe
Hi David, Thanks for the response. Replies inline. On Wed, Nov 9, 2022, at 08:17, David Arthur wrote: > Colin > >> Maybe zk.metadata.migration.enable ? > > Done. I went with "zookeeper.metadata.migration.enable" since our > other ZK configs start with "zookeeper.*" > >> SImilarly, for MigrationR

Re: [VOTE] KIP-866 ZooKeeper to KRaft Migration

2022-11-09 Thread David Arthur
Colin > Maybe zk.metadata.migration.enable ? Done. I went with "zookeeper.metadata.migration.enable" since our other ZK configs start with "zookeeper.*" > SImilarly, for MigrationRecord: can we rename this to ZkMigrationStateRecord? > Then change MigrationState -> ZkMigrationState. Sure > Wi

Re: [VOTE] KIP-866 ZooKeeper to KRaft Migration

2022-11-08 Thread Colin McCabe
Hi David, Looks great. Some questions: I agree with Jun that it would be good to rename metadata.migration.enable to something more zk-specific. Maybe zk.metadata.migration.enable ? SImilarly, for MigrationRecord: can we rename this to ZkMigrationStateRecord? Then change MigrationState -> ZkMi

[VOTE] KIP-866 ZooKeeper to KRaft Migration

2022-11-08 Thread David Arthur
Hello everyone, I'd like to start the vote on KIP-866. https://cwiki.apache.org/confluence/display/KAFKA/KIP-866+ZooKeeper+to+KRaft+Migration Thanks! David Arthur