Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Hi Florin, Yes, you can close the vote. Best, David On Wed, Nov 24, 2021 at 3:19 AM Luke Chen wrote: > > Hi Florin, > I'm not a committer, but yes, this vote be concluded now. > > Thank you. > Luke > > On Wed, Nov 24, 2021 at 3:08 AM Florin Akermann > wrote: > > > Thanks all. > > > > The 72h w

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Hi Florin, I'm not a committer, but yes, this vote be concluded now. Thank you. Luke On Wed, Nov 24, 2021 at 3:08 AM Florin Akermann wrote: > Thanks all. > > The 72h window is through. > > @Comitters can this vote be concluded? > > The vote on KIP-798 would pass with: > 4 binding +1 > 1 non-bin

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Thanks all. The 72h window is through. @Comitters can this vote be concluded? The vote on KIP-798 would pass with: 4 binding +1 1 non-binding +1 no vetoes Thanks, Florin On Tue, 23 Nov 2021 at 06:59, Luke Chen wrote: > Hi Florin, > Thanks for the update! > > +1 (non-binding) > > Thank you.

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Hi Florin, Thanks for the update! +1 (non-binding) Thank you. Luke On Tue, Nov 23, 2021 at 2:00 AM Florin Akermann wrote: > Hi Bill and David, > > Thank you both for the vote. > @David: KIP is updated. > > Florin > > On Mon, 22 Nov 2021 at 18:28, David Jacot > wrote: > > > Hi Florin, > > > >

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Hi Bill and David, Thank you both for the vote. @David: KIP is updated. Florin On Mon, 22 Nov 2021 at 18:28, David Jacot wrote: > Hi Florin, > > Thanks for the KIP. I am +1 (binding). > > There is a small typo in the Proposed Changes section: > `parse.header` should be `parse.headers`. > > Bes

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Hi Florin, Thanks for the KIP. I am +1 (binding). There is a small typo in the Proposed Changes section: `parse.header` should be `parse.headers`. Best, David On Mon, Nov 22, 2021 at 6:20 PM Bill Bejeck wrote: > > Hi Florin, > > Thanks for the KIP, this seems like a very useful addition. > > +

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Hi Florin, Thanks for the KIP, this seems like a very useful addition. +1(binding). -Bill On Mon, Nov 22, 2021 at 12:00 PM Florin Akermann wrote: > Hi Luke and Tom > > @Tom: Thanks for the vote. > > @Luke: Thanks for the feedback. > > I have updated the KIP accordingly with regards to your co

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Hi Luke and Tom @Tom: Thanks for the vote. @Luke: Thanks for the feedback. I have updated the KIP accordingly with regards to your comments on the remaining case (false,false) and the motivation. Regarding the "not only UTF-8": As far as I understand John it is fine to limit the scope for this

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Hi Florin, Thanks for the KIP! +1 (binding), Kind regards, Tom On Mon, Nov 22, 2021 at 6:51 AM Luke Chen wrote: > Hi Florin, > Thanks for the KIP. > > This KIP makes sense to me. Just a comment that the motivation section is > not clearly explain why this KIP is important. > I think John alr

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Hi Florin, Thanks for the KIP. This KIP makes sense to me. Just a comment that the motivation section is not clearly explain why this KIP is important. I think John already mentioned a good motivation, which is to support "not only UTF-8". You should put that into the KIP, and of course if you hav

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Hi John, Thanks for the vote and feedback. The thought occurred to me too. Do I understand it correctly: the current version of the kafka-console-producer cannot be used for anything other than UTF-8 keys and values? (There is no other implementation of MessageReader other than the ConsoleProduc

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

Hi Florin, Thanks for the KIP! I think the assumption that header values are UTF-8 strings might not hold up in the long run, but it seems like we can easily add a property later to specify the format. It seems like this scope is probably a handy addition on its own. I’m +1 (binding) Thanks

[VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer