Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

Thanks, all. I edited the wiki to reflect the implemented behavior by dropping references to special behavior when max_bytes was INT_MAX. cheers, Colin On Sat, Jan 21, 2017, at 09:44, radai wrote: > +1 > > On Fri, Jan 20, 2017 at 9:51 PM, Apurva Mehta > wrote: > > > +1 > > > > On Fri, Jan 20

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

+1 On Fri, Jan 20, 2017 at 9:51 PM, Apurva Mehta wrote: > +1 > > On Fri, Jan 20, 2017 at 5:19 PM, Jason Gustafson > wrote: > > > +1 > > > > On Fri, Jan 20, 2017 at 4:51 PM, Ismael Juma wrote: > > > > > Good catch, Colin. +1 to editing the wiki to match the desired > behaviour > > > and what wa

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

+1 On Fri, Jan 20, 2017 at 5:19 PM, Jason Gustafson wrote: > +1 > > On Fri, Jan 20, 2017 at 4:51 PM, Ismael Juma wrote: > > > Good catch, Colin. +1 to editing the wiki to match the desired behaviour > > and what was implemented in 0.10.1. > > > > Ismael > > > > On Sat, Jan 21, 2017 at 12:19 AM,

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

+1 On Fri, Jan 20, 2017 at 4:51 PM, Ismael Juma wrote: > Good catch, Colin. +1 to editing the wiki to match the desired behaviour > and what was implemented in 0.10.1. > > Ismael > > On Sat, Jan 21, 2017 at 12:19 AM, Colin McCabe wrote: > > > Hi all, > > > > While looking at some code related t

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

Good catch, Colin. +1 to editing the wiki to match the desired behaviour and what was implemented in 0.10.1. Ismael On Sat, Jan 21, 2017 at 12:19 AM, Colin McCabe wrote: > Hi all, > > While looking at some code related to KIP-74, I noticed a slight > discrepancy between the text on the wiki and

[VOTE] KIP-74: Add FetchResponse size limit in bytes

Hi all, While looking at some code related to KIP-74, I noticed a slight discrepancy between the text on the wiki and the implementation. The wiki says that "If max_bytes is Int.MAX_INT, new request behaves exactly like old one." This would mean that if there was a single message that was larger

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

Hi all! I declare the vote as passed. :) Thank you all for valuable input - really appreciate it. I’ll update KIP soon. I believe it should be ready early next week. Andrey. > On 23 Aug 2016, at 12:43, Ismael Juma wrote: > > Thanks Andrey. It has been 7 days since the vote started and there a

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

Thanks Andrey. It has been 7 days since the vote started and there are 3 binding +1 votes (and 3 non-binding +1 votes), so you are free to declare the vote as passed whenever you're ready. :) Will you be able to update the PR to match the KIP soon? Thanks, Ismael On Mon, Aug 22, 2016 at 12:01 PM

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

Thanks. Request parameter renamed: response_max_bytes -> max_bytes. Andrey. > On 19 Aug 2016, at 16:52, Ismael Juma wrote: > > Thanks for the KIP. +1 (binding) with the following suggestion: > > Fetch Request (Version: 3) => replica_id max_wait_time min_bytes > response_max_bytes [topics] > r

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

Thanks for the KIP. +1 (binding) with the following suggestion: Fetch Request (Version: 3) => replica_id max_wait_time min_bytes response_max_bytes [topics] replica_id => INT32 max_wait_time => INT32 min_bytes => INT32 response_max_bytes => INT32 topics => topic [partitions] topic =>

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

+1 (non binding) On Fri, Aug 19, 2016 at 6:20 AM, Manikumar Reddy wrote: > +1 (non-binding) > > This feature help us control memory footprint and allows consumer to > progress on fetching large messages. > > On Fri, Aug 19, 2016 at 10:32 AM, Gwen Shapira wrote: > > > +1 (binding) > > > > On Th

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

+1 (non-binding) This feature help us control memory footprint and allows consumer to progress on fetching large messages. On Fri, Aug 19, 2016 at 10:32 AM, Gwen Shapira wrote: > +1 (binding) > > On Thu, Aug 18, 2016 at 1:47 PM, Andrey L. Neporada > wrote: > > Hi all! > > I’ve modified KIP-74

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

+1 (binding) On Thu, Aug 18, 2016 at 1:47 PM, Andrey L. Neporada wrote: > Hi all! > I’ve modified KIP-74 a little bit (as requested by Jason Gustafson & Jun Rao): > 1) provided more detailed explanation on memory usage (no functional changes) > 2) renamed “fetch.response.max.bytes” -> “fetch.max.

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

+1 (non-binding) Thanks Andrey! On Thu, Aug 18, 2016 at 1:47 PM, Andrey L. Neporada < anepor...@yandex-team.ru> wrote: > Hi all! > I’ve modified KIP-74 a little bit (as requested by Jason Gustafson & Jun > Rao): > 1) provided more detailed explanation on memory usage (no functional > changes) >

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

Hi all! I’ve modified KIP-74 a little bit (as requested by Jason Gustafson & Jun Rao): 1) provided more detailed explanation on memory usage (no functional changes) 2) renamed “fetch.response.max.bytes” -> “fetch.max.bytes” Let’s continue voting in this thread. Thanks! Andrey. > On 17 Aug 2016,

Re: [VOTE] KIP-74: Add FetchResponse size limit in bytes

Andrey, Thanks for the KIP. +1 Jun On Tue, Aug 16, 2016 at 1:32 PM, Andrey L. Neporada < anepor...@yandex-team.ru> wrote: > Hi! > > I would like to initiate the voting process for KIP-74: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 74%3A+Add+Fetch+Response+Size+Limit+in+Bytes > >

[VOTE] KIP-74: Add FetchResponse size limit in bytes

Hi! I would like to initiate the voting process for KIP-74: https://cwiki.apache.org/confluence/display/KAFKA/KIP-74%3A+Add+Fetch+Response+Size+Limit+in+Bytes Thanks, Andrey.