Re: [VOTE] KIP-680: TopologyTestDriver should not require a Properties argument

2020-12-01 Thread Rohit Deshpande
Hello all, I am closing the vote as there are 3 binding votes. Summary of the change: Proposing to add two new constructors to TopologyTestDriver class. 1. One with only topology as parameter 2. Second one with topology and wall clock time as parameter Additional condition is we want to set randomi

Re: [VOTE] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-23 Thread Rohit Deshpande
Thanks John and Matthias. Waiting for 1 more binding vote. Thanks, Rohit On Sat, Nov 21, 2020 at 11:01 AM Matthias J. Sax wrote: > +1 (binding) > > On 11/20/20 7:43 PM, John Roesler wrote: > > Thanks again for the KIP, Rohit. > > > > I’m +1 (binding) > > > > Sorry, I missed your vote thread. > >

Re: [VOTE] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-21 Thread Matthias J. Sax
+1 (binding) On 11/20/20 7:43 PM, John Roesler wrote: > Thanks again for the KIP, Rohit. > > I’m +1 (binding) > > Sorry, I missed your vote thread. > > -John > > On Fri, Nov 20, 2020, at 21:35, Rohit Deshpande wrote: >> Thanks Guozhang. >> Waiting for binding votes. >> Thanks, >> Rohit >> >>

Re: [VOTE] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-20 Thread John Roesler
Thanks again for the KIP, Rohit. I’m +1 (binding) Sorry, I missed your vote thread. -John On Fri, Nov 20, 2020, at 21:35, Rohit Deshpande wrote: > Thanks Guozhang. > Waiting for binding votes. > Thanks, > Rohit > > On Tue, Nov 17, 2020 at 10:13 AM Guozhang Wang wrote: > > > +1, thanks Rohi

Re: [VOTE] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-20 Thread Rohit Deshpande
Thanks Guozhang. Waiting for binding votes. Thanks, Rohit On Tue, Nov 17, 2020 at 10:13 AM Guozhang Wang wrote: > +1, thanks Rohit. > > > Guozhang > > On Sun, Nov 15, 2020 at 11:53 AM Rohit Deshpande > wrote: > > > Hello all, > > I would like to start voting on KIP-680: TopologyTestDriver shoul

Re: [VOTE] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-17 Thread Guozhang Wang
+1, thanks Rohit. Guozhang On Sun, Nov 15, 2020 at 11:53 AM Rohit Deshpande wrote: > Hello all, > I would like to start voting on KIP-680: TopologyTestDriver should not > require a Properties argument. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+n

[VOTE] KIP-680: TopologyTestDriver should not require a Properties argument

2020-11-15 Thread Rohit Deshpande
Hello all, I would like to start voting on KIP-680: TopologyTestDriver should not require a Properties argument. https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument Discuss thread: https://lists.apache.org/thread.html/r5d3d0afc6f