Re: [VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-26 Thread Ismael Juma
Hi Rajini, Good point, `getHostString()` actually returns the original host. The InetSocketAddress code is a bit confusing as it does: String host = null; try { addr = InetAddress.getByName(hostname); } catch(UnknownHostException e) { host = hostnam

Re: [VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-26 Thread Rajini Sivaram
Hi Ismael, I think we resolve early to parse and verify bootstrap servers and use InetSocketAddress as a convenient way to propagate host:port. We also use the opportunity to handle `resolve_canonical_bootstrap_servers_only` since that is applied only to bootstrap servers. In other cases, even tho

Re: [VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-25 Thread Ismael Juma
Badai, I was looking at the code and it seems like we should change how the bootstrap resolution is done as part of this KIP. The way it works at the moment follows: 1. We create a single InetSocketAddress by calling the constructor with the host and port. That invokes InetAddress.getByName(host)

Re: [VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-25 Thread Badai Aqrandista
The vote for KIP-602 has passed with 5 binding and 1 non-binding +1s, and no objections. Thanks everyone for reviews and feedback, Badai On Mon, May 25, 2020 at 12:21 PM Gwen Shapira wrote: > +1 (binding) > > Thank you! > > On Fri, May 22, 2020 at 1:40 AM Badai Aqrandista > wrote: > > > Hi Al

Re: [VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-24 Thread Gwen Shapira
+1 (binding) Thank you! On Fri, May 22, 2020 at 1:40 AM Badai Aqrandista wrote: > Hi All, > > I would like to start the vote on KIP-602: Change default value for > client.dns.lookup > > For reference, here is the KIP wiki: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-602%3A+Chang

Re: [VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-24 Thread Mickael Maison
As one of the authors of KIP-302, I'm very happy to see this change! +1 (binding) Thanks for the KIP On Fri, May 22, 2020 at 10:12 PM John Roesler wrote: > > Thanks, Badai, > > I’m +1 (binding) as well. > > -John > > On Fri, May 22, 2020, at 13:30, Manikumar wrote: > > +1 (binding) > > > > Thanks

Re: [VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-22 Thread John Roesler
Thanks, Badai, I’m +1 (binding) as well. -John On Fri, May 22, 2020, at 13:30, Manikumar wrote: > +1 (binding) > > Thanks for the KIP. > > > On Fri, May 22, 2020 at 11:23 PM Harsha Chintalapani > wrote: > > > +1 (binding). > > -Harsha > > > > On Fri, May 22, 2020 at 10:04 AM Ismael Juma w

Re: [VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-22 Thread Manikumar
+1 (binding) Thanks for the KIP. On Fri, May 22, 2020 at 11:23 PM Harsha Chintalapani wrote: > +1 (binding). > -Harsha > > On Fri, May 22, 2020 at 10:04 AM Ismael Juma wrote: > > > Thanks for the KIP, +1 (binding). > > > > Ismael > > > > On Fri, May 22, 2020 at 1:40 AM Badai Aqrandista > > w

Re: [VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-22 Thread Harsha Chintalapani
+1 (binding). -Harsha On Fri, May 22, 2020 at 10:04 AM Ismael Juma wrote: > Thanks for the KIP, +1 (binding). > > Ismael > > On Fri, May 22, 2020 at 1:40 AM Badai Aqrandista > wrote: > > > Hi All, > > > > I would like to start the vote on KIP-602: Change default value for > > client.dns.lookup

Re: [VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-22 Thread Roger Hoover
+1 (non-binding) Thanks, Badai. On Fri, May 22, 2020 at 10:05 AM Ismael Juma wrote: > Thanks for the KIP, +1 (binding). > > Ismael > > On Fri, May 22, 2020 at 1:40 AM Badai Aqrandista > wrote: > > > Hi All, > > > > I would like to start the vote on KIP-602: Change default value for > > client.

Re: [VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-22 Thread Ismael Juma
Thanks for the KIP, +1 (binding). Ismael On Fri, May 22, 2020 at 1:40 AM Badai Aqrandista wrote: > Hi All, > > I would like to start the vote on KIP-602: Change default value for > client.dns.lookup > > For reference, here is the KIP wiki: > > > https://cwiki.apache.org/confluence/display/KAFKA

[VOTE] KIP-602: Change default value for client.dns.lookup

2020-05-22 Thread Badai Aqrandista
Hi All, I would like to start the vote on KIP-602: Change default value for client.dns.lookup For reference, here is the KIP wiki: https://cwiki.apache.org/confluence/display/KAFKA/KIP-602%3A+Change+default+value+for+client.dns.lookup And discussion thread: https://lists.apache.org/thread.html