Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-04-01 Thread Aneel Nazareth
Thanks everyone, It looks like we have 5 positive votes (3 binding, 2 non-binding) and no negative votes. I'll mark this KIP as accepted, and update the code for KAFKA-9612 to incorporate the recent changes. Cheers, Aneel https://issues.apache.org/jira/browse/KAFKA-9612 On Mon, Mar 30, 2020 at

Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-30 Thread Colin McCabe
Yeah, I will renew my +1 as well in light of the new discussion. Thanks. Colin On Fri, Mar 27, 2020, at 11:22, Kamal Chandraprakash wrote: > +1 (non-binding). Thanks for the KIP! > > On Fri, Mar 27, 2020 at 9:16 PM Gwen Shapira wrote: > > > Vote is still good. We can always add things later i

Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-27 Thread Kamal Chandraprakash
+1 (non-binding). Thanks for the KIP! On Fri, Mar 27, 2020 at 9:16 PM Gwen Shapira wrote: > Vote is still good. We can always add things later if needed. > > On Fri, Mar 27, 2020, 8:15 AM Aneel Nazareth wrote: > > > Hi Colin and Gwen, > > > > I wanted to double-check that your +1 votes were sti

Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-27 Thread Gwen Shapira
Vote is still good. We can always add things later if needed. On Fri, Mar 27, 2020, 8:15 AM Aneel Nazareth wrote: > Hi Colin and Gwen, > > I wanted to double-check that your +1 votes were still good, since the > proposal has been simplified (removing the --delete-config-file option > and taking

Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-27 Thread Aneel Nazareth
Hi Colin and Gwen, I wanted to double-check that your +1 votes were still good, since the proposal has been simplified (removing the --delete-config-file option and taking out the support for reading from STDIN). Thanks! On Fri, Mar 27, 2020 at 10:01 AM Rajini Sivaram wrote: > > +1 (binding) >

Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-27 Thread Rajini Sivaram
+1 (binding) Thanks for the KIP, Aneel! Regards, Rajini On Wed, Mar 25, 2020 at 5:06 AM Gwen Shapira wrote: > +1 (binding), thank you > > On Wed, Mar 18, 2020, 2:26 PM Colin McCabe wrote: > > > +1 (binding). > > > > Thanks, Aneel. > > > > best, > > Colin > > > > On Wed, Mar 18, 2020, at 00:0

Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-24 Thread Gwen Shapira
+1 (binding), thank you On Wed, Mar 18, 2020, 2:26 PM Colin McCabe wrote: > +1 (binding). > > Thanks, Aneel. > > best, > Colin > > On Wed, Mar 18, 2020, at 00:04, David Jacot wrote: > > +1 (non-binding), thanks for the KIP! > > > > David > > > > On Mon, Mar 16, 2020 at 4:06 PM Aneel Nazareth >

Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-18 Thread Colin McCabe
+1 (binding). Thanks, Aneel. best, Colin On Wed, Mar 18, 2020, at 00:04, David Jacot wrote: > +1 (non-binding), thanks for the KIP! > > David > > On Mon, Mar 16, 2020 at 4:06 PM Aneel Nazareth wrote: > > > Hello all, > > > > Thanks to the folks who have given feedback. I've incorporated the

Re: [VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-18 Thread David Jacot
+1 (non-binding), thanks for the KIP! David On Mon, Mar 16, 2020 at 4:06 PM Aneel Nazareth wrote: > Hello all, > > Thanks to the folks who have given feedback. I've incorporated the > suggestions, and think that this is now ready for a vote: > > > https://cwiki.apache.org/confluence/display/KAF

[VOTE] KIP-574: CLI Dynamic Configuration with file input

2020-03-16 Thread Aneel Nazareth
Hello all, Thanks to the folks who have given feedback. I've incorporated the suggestions, and think that this is now ready for a vote: https://cwiki.apache.org/confluence/display/KAFKA/KIP-574%3A+CLI+Dynamic+Configuration+with+file+input Thank you, Aneel