Re: [VOTE] KIP-533: Add default api timeout to AdminClient

2019-11-26 Thread Jason Gustafson
Thanks Colin, that makes sense. I'm going to close this vote. +4 (binding) is the total. -Jason On Tue, Nov 26, 2019 at 9:18 AM Colin McCabe wrote: > +1 (binding). > > Thanks, Jason. > > Maybe we should specify that if the configured request.timeout.ms is > longer than default.api.timeout.ms,

Re: [VOTE] KIP-533: Add default api timeout to AdminClient

2019-11-26 Thread Colin McCabe
+1 (binding). Thanks, Jason. Maybe we should specify that if the configured request.timeout.ms is longer than default.api.timeout.ms, the request timeout will be reduced to fit in the API timeout. best, Colin On Sat, Nov 23, 2019, at 16:59, Ismael Juma wrote: > +1 (binding) > > Note that th

Re: [VOTE] KIP-533: Add default api timeout to AdminClient

2019-11-23 Thread Ismael Juma
+1 (binding) Note that the documentation of the various Options methods will have to be updated as it currently mentions "request timeout". An example from CreateTopicsOptions: "Set the request timeout in milliseconds for this operation or {@code null} if the default request timeout for the Admin

Re: [VOTE] KIP-533: Add default api timeout to AdminClient

2019-11-23 Thread Gwen Shapira
+1 (binding) On Fri, Nov 22, 2019, 1:35 PM Jason Gustafson wrote: > I'd like to start a vote on KIP-533: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-533%3A+Add+default+api+timeout+to+AdminClient > . > > +1 from me > > Thanks, > Jason >

[VOTE] KIP-533: Add default api timeout to AdminClient

2019-11-22 Thread Jason Gustafson
I'd like to start a vote on KIP-533: https://cwiki.apache.org/confluence/display/KAFKA/KIP-533%3A+Add+default+api+timeout+to+AdminClient . +1 from me Thanks, Jason