Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-18 Thread Nikolay Izhikov
Hello. This KIP adopted by commit - https://github.com/apache/kafka/commit/4e094217f7360becd3640a38587e25f9a3bfd4b3 Thanks Sophie and Matthias for the review and merge. Thanks Guozhang, Bill, Matthias, Bruno for the votes and feedback. В Ср, 09/10/2019 в 15:55 +0300, Nikolay Izhikov пишет: > Th

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-09 Thread Nikolay Izhikov
Thanks everyone! After 3+ business days since this thread started, I'm concluding the vote on KIP-527. The KIP has passed with: 3 binding votes from Guzhang, Bill, Matthias. 1 non-binding vote from Bruno. Thank you all for voting! В Вт, 08/10/2019 в 15:17 -0700, Guozhang Wang пишет: > Thanks,

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-08 Thread Guozhang Wang
Thanks, I'm +1 (binding). On Tue, Oct 8, 2019 at 2:33 AM Nikolay Izhikov wrote: > Hello, Guozhang. > > Following added to the KIP: > > > If not null parameters passed then an java.lang.IllegalArgumentException > will be thrown. > > В Пн, 07/10/2019 в 15:51 -0700, Guozhang Wang пишет: > > Hello N

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-08 Thread Nikolay Izhikov
Hello, Guozhang. Following added to the KIP: > If not null parameters passed then an java.lang.IllegalArgumentException will > be thrown. В Пн, 07/10/2019 в 15:51 -0700, Guozhang Wang пишет: > Hello Nikolay, > > Could you clarify in the wiki doc what would happen if the passed in > `byte[] byt

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-07 Thread Guozhang Wang
Hello Nikolay, Could you clarify in the wiki doc what would happen if the passed in `byte[] bytes` or `Void data` parameters are not null? From the example PR we would throw exception here. I think it worth documenting it as part of the contract in the wiki page. Otherwise, I'm +1. Guozhang On

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-07 Thread Bill Bejeck
Thanks for the KIP. +1(binding) -Bill On Mon, Oct 7, 2019 at 5:57 PM Matthias J. Sax wrote: > +1 (binding) > > > -Matthias > > On 10/6/19 8:02 PM, Nikolay Izhikov wrote: > > Hello, > > > > Any additional feedback on this? > > Do we need this in Kafka? > > > > В Ср, 02/10/2019 в 08:30 +0200, Br

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-07 Thread Matthias J. Sax
+1 (binding) -Matthias On 10/6/19 8:02 PM, Nikolay Izhikov wrote: > Hello, > > Any additional feedback on this? > Do we need this in Kafka? > > В Ср, 02/10/2019 в 08:30 +0200, Bruno Cadonna пишет: >> Hi Nikolay, >> >> Thank you for the KIP! >> >> +1 (non-binding) >> >> Best, >> Bruno >> >> On

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-06 Thread Nikolay Izhikov
Hello, Any additional feedback on this? Do we need this in Kafka? В Ср, 02/10/2019 в 08:30 +0200, Bruno Cadonna пишет: > Hi Nikolay, > > Thank you for the KIP! > > +1 (non-binding) > > Best, > Bruno > > On Tue, Oct 1, 2019 at 5:57 PM Nikolay Izhikov wrote: > > > > Hello. > > > > I would l

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-01 Thread Bruno Cadonna
Hi Nikolay, Thank you for the KIP! +1 (non-binding) Best, Bruno On Tue, Oct 1, 2019 at 5:57 PM Nikolay Izhikov wrote: > > Hello. > > I would like to start vote for KIP-527: Add VoidSerde to Serdes > > KIP - > https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+VoidSerde+to+Serdes

[VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-01 Thread Nikolay Izhikov
Hello. I would like to start vote for KIP-527: Add VoidSerde to Serdes KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+VoidSerde+to+Serdes Discussion thread - https://lists.apache.org/thread.html/e6f95799898cc5d6e7d44dfd3fc2206117feb384a0a229a1c781ecd4@%3Cdev.kafka.apache