Re: [VOTE] KIP-517: Add consumer metrics to observe user poll behavior

2019-09-24 Thread Kevin Lu
Hi All, It has been a few days so I am closing the vote now. This KIP has passed with +4 binding votes (Harsha, Manikumar, Jason, Bill) and +3 non-binding votes (Mickael, Maulin, Tom). Regards, Kevin On Fri, Sep 20, 2019 at 1:37 PM Kevin Lu wrote: > Hi All, > > Thanks for the votes! > > I hav

Re: [VOTE] KIP-517: Add consumer metrics to observe user poll behavior

2019-09-20 Thread Kevin Lu
Hi All, Thanks for the votes! I have to point out that Jason brought up a good point about making the " *poll-idle-ratio*" measurement consistent with existing broker idle metrics so we made a small change. Previously it was calculated as: > poll-idle-ratio = time-between-poll / time-inside-pol

Re: [VOTE] KIP-517: Add consumer metrics to observe user poll behavior

2019-09-20 Thread Bill Bejeck
+1 (binding) Thanks for the KIP! -Bill On Fri, Sep 20, 2019 at 1:28 PM Jason Gustafson wrote: > +1 Thanks! > > On Thu, Sep 19, 2019 at 11:22 PM Tom Bentley wrote: > > > +1 (non-binding). > > > > On Fri, Sep 20, 2019 at 7:00 AM Maulin Vasavada < > maulin.vasav...@gmail.com > > > > > wrote: > >

Re: [VOTE] KIP-517: Add consumer metrics to observe user poll behavior

2019-09-20 Thread Jason Gustafson
+1 Thanks! On Thu, Sep 19, 2019 at 11:22 PM Tom Bentley wrote: > +1 (non-binding). > > On Fri, Sep 20, 2019 at 7:00 AM Maulin Vasavada > > wrote: > > > +1 (non-binding). Thanks for the KIP. > > > > On Thu, Sep 19, 2019 at 10:38 PM Manikumar > > wrote: > > > > > +1 (binding), Thanks for the KIP

Re: [VOTE] KIP-517: Add consumer metrics to observe user poll behavior

2019-09-19 Thread Tom Bentley
+1 (non-binding). On Fri, Sep 20, 2019 at 7:00 AM Maulin Vasavada wrote: > +1 (non-binding). Thanks for the KIP. > > On Thu, Sep 19, 2019 at 10:38 PM Manikumar > wrote: > > > +1 (binding), Thanks for the KIP. > > > > On Fri, Sep 20, 2019 at 12:41 AM Harsha Chintalapani > > wrote: > > > > > +1

Re: [VOTE] KIP-517: Add consumer metrics to observe user poll behavior

2019-09-19 Thread Maulin Vasavada
+1 (non-binding). Thanks for the KIP. On Thu, Sep 19, 2019 at 10:38 PM Manikumar wrote: > +1 (binding), Thanks for the KIP. > > On Fri, Sep 20, 2019 at 12:41 AM Harsha Chintalapani > wrote: > > > +1 (binding). Thanks for the KIP. > > > > -Harsha > > > > On Wed, Sep 18, 2019 at 9:07 AM Mickael M

Re: [VOTE] KIP-517: Add consumer metrics to observe user poll behavior

2019-09-19 Thread Manikumar
+1 (binding), Thanks for the KIP. On Fri, Sep 20, 2019 at 12:41 AM Harsha Chintalapani wrote: > +1 (binding). Thanks for the KIP. > > -Harsha > > On Wed, Sep 18, 2019 at 9:07 AM Mickael Maison > wrote: > > > +1 (non binding) > > Thanks for the KIP, I can see this being really useful! > > > > On

Re: [VOTE] KIP-517: Add consumer metrics to observe user poll behavior

2019-09-19 Thread Harsha Chintalapani
+1 (binding). Thanks for the KIP. -Harsha On Wed, Sep 18, 2019 at 9:07 AM Mickael Maison wrote: > +1 (non binding) > Thanks for the KIP, I can see this being really useful! > > On Wed, Sep 18, 2019 at 4:40 PM Kevin Lu wrote: > > > > Hi All, > > > > Since we have a bit of support, I'd like to s

Re: [VOTE] KIP-517: Add consumer metrics to observe user poll behavior

2019-09-18 Thread Mickael Maison
+1 (non binding) Thanks for the KIP, I can see this being really useful! On Wed, Sep 18, 2019 at 4:40 PM Kevin Lu wrote: > > Hi All, > > Since we have a bit of support, I'd like to start the vote on KIP-517: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-517%3A+Add+consumer+metrics+to+ob

[VOTE] KIP-517: Add consumer metrics to observe user poll behavior

2019-09-18 Thread Kevin Lu
Hi All, Since we have a bit of support, I'd like to start the vote on KIP-517: https://cwiki.apache.org/confluence/display/KAFKA/KIP-517%3A+Add+consumer+metrics+to+observe+user+poll+behavior Thanks! Regards, Kevin