Re: [VOTE] KIP-460: Admin Leader Election RPC

2019-06-04 Thread Jose Armando Garcia Sancio
Hi all, During the implementation of KIP-460, we discovered that we had to make some minor changes to the design. I have updated the KIP wiki[1]. You can see the difference here[2]. At a high-level we made the following changes: 1. Added a top level ErrorCode to the response for errors that a

Re: [VOTE] KIP-460: Admin Leader Election RPC

2019-05-07 Thread Jose Armando Garcia Sancio
Thanks Gwen for the clarification! On Mon, May 6, 2019 at 5:03 PM Gwen Shapira wrote: > All committer votes are binding, so you have binding +1 from Colin, Jason > and myself - which is just the 3 you need for the KIP to be accepted. > Mickael added non-binding community support, which is great

Re: [VOTE] KIP-460: Admin Leader Election RPC

2019-05-06 Thread Gwen Shapira
All committer votes are binding, so you have binding +1 from Colin, Jason and myself - which is just the 3 you need for the KIP to be accepted. Mickael added non-binding community support, which is great signal as well. On Mon, May 6, 2019 at 4:39 PM Jose Armando Garcia Sancio < jsan...@confluent.

Re: [VOTE] KIP-460: Admin Leader Election RPC

2019-05-06 Thread Jose Armando Garcia Sancio
I am closing the voting. KIP is accepted with: +1 (binding): Colin McCabe +1 (non-binding): Jason Gustafson, Gwen Shapira, Mickael Maison Thanks! On Fri, May 3, 2019 at 9:59 AM Mickael Maison wrote: > +1 (non binding) > Thanks for the KIP > > On Thu, May 2, 2019 at 11:02 PM Colin McCabe wrote

Re: [VOTE] KIP-460: Admin Leader Election RPC

2019-05-03 Thread Mickael Maison
+1 (non binding) Thanks for the KIP On Thu, May 2, 2019 at 11:02 PM Colin McCabe wrote: > > +1 (binding) > > thanks, Jose. > > best, > Colin > > On Wed, May 1, 2019, at 14:44, Jose Armando Garcia Sancio wrote: > > Hi all, > > > > I would like to start the voting for KIP-460: > > https://cwiki.apa

Re: [VOTE] KIP-460: Admin Leader Election RPC

2019-05-02 Thread Colin McCabe
+1 (binding) thanks, Jose. best, Colin On Wed, May 1, 2019, at 14:44, Jose Armando Garcia Sancio wrote: > Hi all, > > I would like to start the voting for KIP-460: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-460%3A+Admin+Leader+Election+RPC > > The thread discussion is here: > http

Re: [VOTE] KIP-460: Admin Leader Election RPC

2019-05-01 Thread Gwen Shapira
+1 On Wed, May 1, 2019 at 2:44 PM Jose Armando Garcia Sancio < jsan...@confluent.io> wrote: > Hi all, > > I would like to start the voting for KIP-460: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-460%3A+Admin+Leader+Election+RPC > > The thread discussion is here: > https://www.mail-

Re: [VOTE] KIP-460: Admin Leader Election RPC

2019-05-01 Thread Jason Gustafson
+1 Thanks for the KIP. -Jason On Wed, May 1, 2019 at 2:44 PM Jose Armando Garcia Sancio < jsan...@confluent.io> wrote: > Hi all, > > I would like to start the voting for KIP-460: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-460%3A+Admin+Leader+Election+RPC > > The thread discussion

[VOTE] KIP-460: Admin Leader Election RPC

2019-05-01 Thread Jose Armando Garcia Sancio
Hi all, I would like to start the voting for KIP-460: https://cwiki.apache.org/confluence/display/KAFKA/KIP-460%3A+Admin+Leader+Election+RPC The thread discussion is here: https://www.mail-archive.com/dev@kafka.apache.org/msg97226.html Thanks! -Jose