Re: [VOTE] KIP-444: Refactor and Augment Metrics for Kafka Streams

2020-04-07 Thread Bruno Cadonna
Hi Guozhang, Thank you for the additions. Best, Bruno On Fri, Apr 3, 2020 at 2:08 AM Guozhang Wang wrote: > > A correction for the previous email: > > >- number of alive global threads, INFO >- number of alive restore threads, INFO > > > These two metrics are not going to be added in th

Re: [VOTE] KIP-444: Refactor and Augment Metrics for Kafka Streams

2020-04-06 Thread Matthias J. Sax
Thanks Guozhang. SGTM. On 4/2/20 5:08 PM, Guozhang Wang wrote: > A correction for the previous email: > > >- number of alive global threads, INFO >- number of alive restore threads, INFO > > > These two metrics are not going to be added in this KIP, since we do not > have restore threa

Re: [VOTE] KIP-444: Refactor and Augment Metrics for Kafka Streams

2020-04-02 Thread Guozhang Wang
A correction for the previous email: - number of alive global threads, INFO - number of alive restore threads, INFO These two metrics are not going to be added in this KIP, since we do not have restore threads in Kafka Streams yet. Guozhang On Thu, Apr 2, 2020 at 2:02 PM Guozhang Wang

Re: [VOTE] KIP-444: Refactor and Augment Metrics for Kafka Streams

2020-04-02 Thread Guozhang Wang
Hello all, While implementing the last piece of this KIP for the coming 2.6 release, I realized that it is important to cover the following monitoring metrics as well so I'd propose adding them as part of KIP-444 too: Instance-level: - number of alive stream threads, INFO - number of alive

Re: [VOTE] KIP-444: Refactor and Augment Metrics for Kafka Streams

2019-09-09 Thread Matthias J. Sax
+1 (binding) -Matthias On 9/5/19 11:47 AM, Guozhang Wang wrote: > +1 from myself. > > I'm now officially closing this voting thread with the following tally: > > binding +1: 3 (Guozhang, Bill, Matthias voted on the DISCUSS thread). > non-binding +1: 2 (Bruno, John). > > > Guozhang > > > On

Re: [VOTE] KIP-444: Refactor and Augment Metrics for Kafka Streams

2019-09-05 Thread Guozhang Wang
+1 from myself. I'm now officially closing this voting thread with the following tally: binding +1: 3 (Guozhang, Bill, Matthias voted on the DISCUSS thread). non-binding +1: 2 (Bruno, John). Guozhang On Thu, Aug 22, 2019 at 8:16 AM Bill Bejeck wrote: > +1 (binding) > > -Bill > > On Thu, Aug

Re: [VOTE] KIP-444: Refactor and Augment Metrics for Kafka Streams

2019-08-22 Thread Bill Bejeck
+1 (binding) -Bill On Thu, Aug 22, 2019 at 10:55 AM John Roesler wrote: > Hi Guozhang, thanks for cleaning this up. > > I'm +1 (non-binding) > > Thanks, > -John > > On Thu, Aug 22, 2019 at 2:26 AM Bruno Cadonna wrote: > > > Hi Guozhang, > > > > +1 (non-binding) > > > > Thank you for driving th

Re: [VOTE] KIP-444: Refactor and Augment Metrics for Kafka Streams

2019-08-22 Thread John Roesler
Hi Guozhang, thanks for cleaning this up. I'm +1 (non-binding) Thanks, -John On Thu, Aug 22, 2019 at 2:26 AM Bruno Cadonna wrote: > Hi Guozhang, > > +1 (non-binding) > > Thank you for driving this! > Bruno > > On Tue, Aug 20, 2019 at 8:29 PM Guozhang Wang wrote: > > > > Hello folks, > > > > I

Re: [VOTE] KIP-444: Refactor and Augment Metrics for Kafka Streams

2019-08-22 Thread Bruno Cadonna
Hi Guozhang, +1 (non-binding) Thank you for driving this! Bruno On Tue, Aug 20, 2019 at 8:29 PM Guozhang Wang wrote: > > Hello folks, > > I'd like to start a voting thread the following KIP to improve the Kafka > Streams metrics mechanism to users. This includes 1) renaming changes in > the pub

[VOTE] KIP-444: Refactor and Augment Metrics for Kafka Streams

2019-08-20 Thread Guozhang Wang
Hello folks, I'd like to start a voting thread the following KIP to improve the Kafka Streams metrics mechanism to users. This includes 1) renaming changes in the public StreamsMetrics utils API, and 2) a major cleanup on the Streams' own built-in metrics hierarchy. Details can be found here: ht