Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

Hi all, We discovered an issue with how compatibility was handled in this KIP. There should always be a way for the client to know that the information that was requested was omitted by the broker because it was too old. I changed the "Compatibility, Deprecation, and Migration Plan" to add so

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

The vote has passed with 5 binding votes (Harsha, Gwen, Manikumar, Colin, me) and 2 non-binding votes (Satish, Mickael). I will update the KIP page. Many thanks to everyone for the feedback and votes. Regards, Rajini On Tue, Feb 26, 2019 at 6:41 PM Rajini Sivaram wrote: > Thanks Colin, I hav

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

Thanks Colin, I have updated the KIP to mention that we don't return UNKNOWN, ANY or ALL. Regards, Rajini On Tue, Feb 26, 2019 at 6:10 PM Colin McCabe wrote: > Thanks, Rajini! Just to make it clear, can we spell out that we don't set > the UNKNOWN, ANY, or ALL bits ever? > > +1 once that's re

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

Thanks, Rajini! Just to make it clear, can we spell out that we don't set the UNKNOWN, ANY, or ALL bits ever? +1 once that's resolved. cheers, Colin On Mon, Feb 25, 2019, at 04:11, Rajini Sivaram wrote: > Hi Colin, > > Yes, it makes sense to reduce response size by using bit fields. Updated

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

Hi, Thanks for the KIP. +1( binding). Thanks, On Mon, Feb 25, 2019 at 6:28 PM Rajini Sivaram wrote: > Thanks Mickael. > > I thought I had to list the type only once when the same field appears > twice (the field itself is listed both for cluster and topic). But you are > the second person who

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

Thanks Mickael. I thought I had to list the type only once when the same field appears twice (the field itself is listed both for cluster and topic). But you are the second person who brought this up, so I must be mistaken. I have added the type in both places to avoid confusion. On Mon, Feb 25,

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

+1 (non binding) In the Metadata v8 section, it looks like the "authorized_operations" field is missing under "topic_metadata". There's only the top-level "authorized_operations" field. On Mon, Feb 25, 2019 at 12:11 PM Rajini Sivaram wrote: > > Hi Colin, > > Yes, it makes sense to reduce response

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

Hi Colin, Yes, it makes sense to reduce response size by using bit fields. Updated the KIP. I have also updated the KIP to say that clients will ignore any bits set by the broker that are unknown to the client, so there will be no UNKNOWN operations in the set returned by AdminClient. Brokers may

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

Hi Rajini, Thanks for the explanations. On Fri, Feb 22, 2019, at 11:59, Rajini Sivaram wrote: > Hi Colin, > > Thanks for the review. Sorry I meant that an array of INT8's, each of which > is an AclOperation code will be returned. I have clarified that in the KIP. Do you think it's worth conside

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

Hi Colin, Thanks for the review. Sorry I meant that an array of INT8's, each of which is an AclOperation code will be returned. I have clarified that in the KIP. All permitted operations will be returned from the set of supported operations on each resource. This is regardless of whether the acce

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

Hi Rajini, Thanks for the KIP! The KIP specifies that "Authorized operations will be returned as [an] INT8 consistent with [the] AclOperation used in ACL requests and responses." But there may be more than one AclOperation that is applied to a given resource. For example, a principal may hav

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

+1 On Thu, Feb 21, 2019 at 2:28 AM Rajini Sivaram wrote: > > I would like to start vote on KIP-430 to optionally obtain authorized > operations when describing resources: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-430+-+Return+Authorized+Operations+in+Describe+Responses > > Thank y

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

+1 (binding). Thanks, Harsha On Thu, Feb 21, 2019, at 2:49 AM, Satish Duggana wrote: > Thanks for the KIP, +1 (non-binding) > > ~Satish. > > On Thu, Feb 21, 2019 at 3:58 PM Rajini Sivaram > wrote: > > > > I would like to start vote on KIP-430 to optionally obtain authorized > > operations whe

Re: [VOTE] KIP-430 - Return Authorized Operations in Describe Responses

Thanks for the KIP, +1 (non-binding) ~Satish. On Thu, Feb 21, 2019 at 3:58 PM Rajini Sivaram wrote: > > I would like to start vote on KIP-430 to optionally obtain authorized > operations when describing resources: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-430+-+Return+Authorized+

[VOTE] KIP-430 - Return Authorized Operations in Describe Responses

I would like to start vote on KIP-430 to optionally obtain authorized operations when describing resources: https://cwiki.apache.org/confluence/display/KAFKA/KIP-430+-+Return+Authorized+Operations+in+Describe+Responses Thank you, Rajini